bluetooth: Update BluetoothGATTCharacteristic.value on writeValue

bluetooth: Update BluetoothCharacteristic.value on writeValue

BUG=507415
Committed: https://crrev.com/f5ab6b86e41c7abbc468ff8b7c3aac245cd2c048
Cr-Commit-Position: refs/heads/master@{#370733}

[fbeaufortchromium, 2016-01-20 09:16:02]

fbeaufort@chromium.org changed reviewers:
+ fbeaufort@chromium.org, ortuno@chromium.org, yhirano@chromium.org

[fbeaufortchromium, 2016-01-20 09:16:49]

fbeaufort@chromium.org changed reviewers:
+ mkwst@chromium.org

[fbeaufortchromium, 2016-01-20 09:16:50]

mkwst@chromium.org: Please review changes in

[fbeaufortchromium, 2016-01-20 09:23:04]

As mentioned in
http://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothgattcharacteristi...,
BluetoothGATTCharacteristic.value needs to be updated when a new value is
written.

mkwst@chromium.org: Please review changes in
content/common/bluetooth/bluetooth_messages.h

yhirano@chromium.org: Please review changes in
third_party/WebKit/LayoutTests/bluetooth/writeValue.html

ortuno@chromium.org: Please review the overall implementation

[ortuno, 2016-01-20 16:34:40]

https://codereview.chromium.org/1611443002/diff/1/content/renderer/bluetooth/...
File content/renderer/bluetooth/bluetooth_dispatcher.cc (right):

https://codereview.chromium.org/1611443002/diff/1/content/renderer/bluetooth/...
content/renderer/bluetooth/bluetooth_dispatcher.cc:669: const
std::vector<uint8_t>& value) {
I don't think you need to send back the value. You can add a
CharacteristicWriteValueRequest struct and save the value there; we do something
similar for getPrimaryService and getCharacteristic.

[yhirano, 2016-01-21 07:52:22]

writeValue.html lgtm

[Mike West, 2016-01-21 09:29:04]

IPC LGTM.

[fbeaufortchromium, 2016-01-21 11:34:06]

Patchset #2 (id:20001) has been deleted

[fbeaufortchromium, 2016-01-21 13:29:32]

Patchset #2 (id:40001) has been deleted

[fbeaufortchromium, 2016-01-21 13:31:38]

On 2016/01/20 16:34:40, ortuno wrote:
>
https://codereview.chromium.org/1611443002/diff/1/content/renderer/bluetooth/...
> File content/renderer/bluetooth/bluetooth_dispatcher.cc (right):
> 
>
https://codereview.chromium.org/1611443002/diff/1/content/renderer/bluetooth/...
> content/renderer/bluetooth/bluetooth_dispatcher.cc:669: const
> std::vector<uint8_t>& value) {
> I don't think you need to send back the value. You can add a
> CharacteristicWriteValueRequest struct and save the value there; we do
something
> similar for getPrimaryService and getCharacteristic.

Done.

[ortuno, 2016-01-21 16:41:32]

lgtm with one nit

https://codereview.chromium.org/1611443002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp
(right):

https://codereview.chromium.org/1611443002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp:159:
m_webCharacteristic->setValue(domDataView);
nit: You can just pass the result of ConvertWebVectorToDataView directly to
setValue()

[fbeaufortchromium, 2016-01-21 16:55:42]

On 2016/01/21 16:41:32, ortuno wrote:
> lgtm with one nit
> 
>
https://codereview.chromium.org/1611443002/diff/60001/third_party/WebKit/Sour...
> File
third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp
> (right):
> 
>
https://codereview.chromium.org/1611443002/diff/60001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp:159:
> m_webCharacteristic->setValue(domDataView);
> nit: You can just pass the result of ConvertWebVectorToDataView directly to
> setValue()

Done.

[fbeaufortchromium, 2016-01-21 16:55:48]

The CQ bit was checked by fbeaufort@chromium.org

[fbeaufortchromium, 2016-01-21 16:55:48]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
yhirano@chromium.org, ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/1611443002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-01-21 16:56:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1611443002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1611443002/80001

[commit-bot: I haz the power, 2016-01-21 18:30:50]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-01-21 18:32:26]

Description was changed from

==========
bluetooth: Update BluetoothCharacteristic.value on writeValue

BUG=507415
==========

to

==========
bluetooth: Update BluetoothCharacteristic.value on writeValue

BUG=507415

Committed: https://crrev.com/f5ab6b86e41c7abbc468ff8b7c3aac245cd2c048
Cr-Commit-Position: refs/heads/master@{#370733}
==========

[commit-bot: I haz the power, 2016-01-21 18:32:27]

Patchset 3 (id:??) landed as
https://crrev.com/f5ab6b86e41c7abbc468ff8b7c3aac245cd2c048
Cr-Commit-Position: refs/heads/master@{#370733}