Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html

Issue 1603893002: bluetooth: Switch BluetoothGattCharacteristic.value to DataView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetoothValue
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DOMDataView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html b/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html
index d21107a0ca5f9307ef29bf8474b4cfb88e24fd2d..a8fe5fd9b0dfe092f2279eaef73c1962a622a3e3 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html
@@ -18,10 +18,10 @@ promise_test(() => {
'readValue',
'characteristicvaluechanged');
}).then(results => {
- let read_value = new Uint8Array(results[0]);
- let event_value = new Uint8Array(results[1]);
- // TODO(ortuno): The ArrayBuffer used to resolve the promise
- // should be the same ArrayBuffer as the one saved in the
+ let read_value = results[0].buffer;
+ let event_value = results[1].buffer;
+ // TODO(ortuno): The DataView used to resolve the promise
+ // should be the same DataView as the one saved in the
// characteristic.
// http://crbug.com/543347
// assert_equals(event.target.value, value);
@@ -41,11 +41,11 @@ promise_test(() => {
'characteristicvaluechanged',
3 /* attach 3 listeners */);
}).then(results => {
- let read_value = new Uint8Array(results[0]);
- let event_values = results.slice(1).map(v => new Uint8Array(v));
+ let read_value = results[0].buffer;
+ let event_values = results.slice(1).map(v => v.buffer);
for (let event_value of event_values) {
- // TODO(ortuno): The ArrayBuffer used to resolve the promise
- // should be the same ArrayBuffer as the one saved in the
+ // TODO(ortuno): The DataView used to resolve the promise
+ // should be the same DataView as the one saved in the
// characteristic.
// http://crbug.com/543347
// assert_equals(event.target.value, value);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DOMDataView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698