Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 16023011: Make RTC work on Firefox (mostly). (Closed)

Created:
7 years, 7 months ago by Emily Fortuna
Modified:
7 years, 6 months ago
Reviewers:
sra1, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 5

Patch Set 2 : #

Total comments: 14

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -22 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 4 chunks +20 lines, -8 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/html/rtc_test.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_RTCIceCandidate.darttemplate View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate View 1 2 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Emily Fortuna
The rest should work (onicecandidate, etc) once the currently nightly gets moved to release FF.
7 years, 7 months ago (2013-05-24 21:33:20 UTC) #1
blois
https://codereview.chromium.org/16023011/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/16023011/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart#newcode17290 sdk/lib/html/dart2js/html_dart2js.dart:17290: Device.isFirefox ? '${Device.propertyPrefix}RTCIceCandidate' : Better to do something like: ...
7 years, 7 months ago (2013-05-24 21:42:59 UTC) #2
Emily Fortuna
https://codereview.chromium.org/16023011/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/16023011/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart#newcode17290 sdk/lib/html/dart2js/html_dart2js.dart:17290: Device.isFirefox ? '${Device.propertyPrefix}RTCIceCandidate' : On 2013/05/24 21:42:59, blois wrote: ...
7 years, 7 months ago (2013-05-24 22:40:54 UTC) #3
sra1
https://codereview.chromium.org/16023011/diff/8001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/16023011/diff/8001/sdk/lib/html/dart2js/html_dart2js.dart#newcode17292 sdk/lib/html/dart2js/html_dart2js.dart:17292: var constructorName = JS('RtcIceCandidate', 'window[#]', The JavaScript constructor function ...
7 years, 7 months ago (2013-05-24 22:53:43 UTC) #4
Emily Fortuna
https://codereview.chromium.org/16023011/diff/8001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/16023011/diff/8001/sdk/lib/html/dart2js/html_dart2js.dart#newcode17292 sdk/lib/html/dart2js/html_dart2js.dart:17292: var constructorName = JS('RtcIceCandidate', 'window[#]', On 2013/05/24 22:53:43, sra1 ...
7 years, 7 months ago (2013-05-24 23:47:25 UTC) #5
sra1
LGTM if Pete thinks this is OK.
7 years, 7 months ago (2013-05-27 20:51:33 UTC) #6
blois
lgtm
7 years, 6 months ago (2013-05-28 16:25:08 UTC) #7
Emily Fortuna
7 years, 6 months ago (2013-05-28 17:55:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r23298 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698