Make RTC work on Firefox (mostly).

sdk/lib/html/dart2js/html_dart2js.dart

 /// The Dart HTML library.
 library dart.dom.html;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:_collection-dev' hide Symbol;
 import 'dart:html_common';
 import 'dart:indexed_db';
 import 'dart:isolate';
 import 'dart:json' as json;
@@ skipping 17268 matching lines @@
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 @DomName('RTCIceCandidate')
 @SupportedBrowser(SupportedBrowser.CHROME)
 @Experimental
 class RtcIceCandidate native "RTCIceCandidate" {
   factory RtcIceCandidate(Map dictionary) {
-    return JS('RtcIceCandidate', 'new RTCIceCandidate(#)',
+    var constructorName = JS('RtcIceCandidate', 'window[#]',
+        Device.isFirefox ? '${Device.propertyPrefix}RTCIceCandidate' : 

[blois, 2013/05/24 21:42:59]

Better to do something like:

new (window.RTCIceCandidate || window.mozRTCIceCandidate)();

This way it always uses the unprefixed when available.

Also, is it:
mozRTCIceCandidate
or:
MozRTCIceCandidate

[Emily Fortuna, 2013/05/24 22:40:54]

As discussed offline, this doesn't work because RTCIceCandidate is always
already defined, but you can only consturct the mozRTC.. version. I added a TODO
to get rid of the current code when it's saner in Firefox.

+        'RTCIceCandidate');
+    return JS('RtcIceCandidate', 'new #(#)', constructorName,
         convertDartToNative_SerializedScriptValue(dictionary));
   }
 
   @DomName('RTCIceCandidate.candidate')
   @DocsEditable
   final String candidate;
 
   @DomName('RTCIceCandidate.sdpMLineIndex')
   @DocsEditable
   final int sdpMLineIndex;
@@ skipping 39 matching lines @@
   }
 
   /**
    * Checks if Real Time Communication (RTC) APIs are supported and enabled on
    * the current platform.
    */
   static bool get supported {
     // Currently in Firefox some of the RTC elements are defined but throw an
     // error unless the user has specifically enabled them in their
     // about:config. So we have to construct an element to actually test if RTC
-    // is supported at at the given time.
+    // is supported at at the given time. Additionally, Firefox only supports IP
+    // numbers (currently), so we test with a random IP address.
+    // See https://bugzilla.mozilla.org/show_bug.cgi?id=837919 for details.
     try {
-      var c = new RtcPeerConnection({"iceServers": [ {"url":"stun:foo.com"}]});
+      var c = new RtcPeerConnection(
+          {"iceServers": [ {"url":"stun:216.93.246.18"}]});

[blois, 2013/05/24 21:42:59]

This feels very hacky for a supported check. Can we just check if the basic type
exists and tell people that they need to do further checks on their own?

[Emily Fortuna, 2013/05/24 22:40:54]

The deal is, the basic type always "exists" in firefox, even if it's not
"enabled" (see comment starting on line 17348).  It would be pretty confusing
and misleading to the user to claim that it's working, but then not actually
work. Because this doesn't have any side effects (aside from creating an object,
but it doesn't cause anything to "start happening"), and it's only going to be
called if someone is actually interested in using this functionality, I think it
is okay.

       return c is RtcPeerConnection;
     } catch (_) {}
     return false;
   }
   Future<RtcSessionDescription> createOffer([Map mediaConstraints]) {
     var completer = new Completer<RtcSessionDescription>();
     _createOffer(
         (value) { completer.complete(value); },
         (error) { completer.completeError(error); }, mediaConstraints);
     return completer.future;
@@ skipping 264 matching lines @@
 
   @DomName('RTCPeerConnection.onremovestream')
   @DocsEditable
   Stream<MediaStreamEvent> get onRemoveStream => removeStreamEvent.forTarget(this);
 
   @DomName('RTCPeerConnection.onsignalingstatechange')
   @DocsEditable
   Stream<Event> get onSignalingStateChange => signalingStateChangeEvent.forTarget(this);
 
 }
-
-
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 @DomName('RTCSessionDescription')
 @SupportedBrowser(SupportedBrowser.CHROME)
 @Experimental
 class RtcSessionDescription native "RTCSessionDescription" {
   factory RtcSessionDescription(Map dictionary) {
-    return JS('RtcSessionDescription', 'new RTCSessionDescription(#)',
+    var constructorName = JS('RtcSessionDescription', 'window[#]',
+        Device.isFirefox ? '${Device.propertyPrefix}RTCSessionDescription' : 
+        'RTCSessionDescription');
+    return JS('RtcSessionDescription', 
+        'new #(#)', constructorName,

[blois, 2013/05/24 21:42:59]

Ditto from earlier comment.

         convertDartToNative_SerializedScriptValue(dictionary));
   }
 
   @DomName('RTCSessionDescription.sdp')
   @DocsEditable
   String sdp;
 
   @DomName('RTCSessionDescription.type')
   @DocsEditable
   String type;
@@ skipping 10693 matching lines @@
       _position = nextPosition;
       return true;
     }
     _current = null;
     _position = _array.length;
     return false;
   }
 
   T get current => _current;
 }