tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate - Issue 16023011: Make RTC work on Firefox (mostly).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate

Issue 16023011: Make RTC work on Firefox (mostly). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/dart2js/impl_RTCIceCandidate.darttemplate ('k') | tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate

diff --git a/tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate b/tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate

index f9b879e43c9fd380efd30752f2c889fbefdb64fe..6dd65b4ff4608c29ccff2464e1a4e72555b7c83c 100644

--- a/tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate

+++ b/tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate

@@ -6,7 +6,14 @@ part of $LIBRARYNAME;

$(ANNOTATIONS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

factory $CLASSNAME(Map dictionary) {

- return JS('RtcSessionDescription', 'new RTCSessionDescription(#)',

+ // TODO(efortuna): Remove this check if when you can actually construct with

+ // the unprefixed RTCIceCandidate in Firefox (currently both are defined,

+ // but one can't be used as a constructor).

+ var constructorName = JS('', 'window[#]',

+ Device.isFirefox ? '${Device.propertyPrefix}RTCSessionDescription' :

+ 'RTCSessionDescription');

+ return JS('RtcSessionDescription',

+ 'new #(#)', constructorName,

convertDartToNative_SerializedScriptValue(dictionary));

}

$!MEMBERS