third_party/WebKit/Source/platform/network/ResourceResponse.cpp - Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel.

Unified Diff: third_party/WebKit/Source/platform/network/ResourceResponse.cpp

Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address latest comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js ('K') | « third_party/WebKit/Source/platform/network/ResourceResponse.h ('k') | third_party/WebKit/public/platform/WebURLResponse.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/network/ResourceResponse.cpp

diff --git a/third_party/WebKit/Source/platform/network/ResourceResponse.cpp b/third_party/WebKit/Source/platform/network/ResourceResponse.cpp

index e0ba248dd67d74fff188c65d74858904c3b5e11d..4c3fe12505d885cb1087ba737c35466a9dfd818d 100644

--- a/third_party/WebKit/Source/platform/network/ResourceResponse.cpp

+++ b/third_party/WebKit/Source/platform/network/ResourceResponse.cpp

@@ -124,6 +124,9 @@ ResourceResponse::ResourceResponse(CrossThreadResourceResponseData* data)

m_securityDetails.keyExchange = data->m_securityDetails.keyExchange;

m_securityDetails.mac = data->m_securityDetails.mac;

m_securityDetails.certID = data->m_securityDetails.certID;

+ m_securityDetails.numUnknownSCTs = data->m_securityDetails.numUnknownSCTs;

+ m_securityDetails.numInvalidSCTs = data->m_securityDetails.numInvalidSCTs;

+ m_securityDetails.numValidSCTs = data->m_securityDetails.numValidSCTs;

m_httpVersion = data->m_httpVersion;

m_appCacheID = data->m_appCacheID;

m_appCacheManifestURL = data->m_appCacheManifestURL.copy();

@@ -168,6 +171,9 @@ PassOwnPtr<CrossThreadResourceResponseData> ResourceResponse::copyData() const

data->m_securityDetails.keyExchange = m_securityDetails.keyExchange.isolatedCopy();

data->m_securityDetails.mac = m_securityDetails.mac.isolatedCopy();

data->m_securityDetails.certID = m_securityDetails.certID;

+ data->m_securityDetails.numUnknownSCTs = m_securityDetails.numUnknownSCTs;

+ data->m_securityDetails.numInvalidSCTs = m_securityDetails.numInvalidSCTs;

+ data->m_securityDetails.numValidSCTs = m_securityDetails.numValidSCTs;

data->m_httpVersion = m_httpVersion;

data->m_appCacheID = m_appCacheID;

data->m_appCacheManifestURL = m_appCacheManifestURL.copy();

@@ -318,13 +324,16 @@ void ResourceResponse::updateHeaderParsedState(const AtomicString& name)

m_haveParsedLastModifiedHeader = false;

}

-void ResourceResponse::setSecurityDetails(const String& protocol, const String& keyExchange, const String& cipher, const String& mac, int certId)

+void ResourceResponse::setSecurityDetails(const String& protocol, const String& keyExchange, const String& cipher, const String& mac, int certId, size_t numUnknownScts, size_t numInvalidScts, size_t numValidScts)

{

m_securityDetails.protocol = protocol;

m_securityDetails.keyExchange = keyExchange;

m_securityDetails.cipher = cipher;

m_securityDetails.mac = mac;

m_securityDetails.certID = certId;

+ m_securityDetails.numUnknownSCTs = numUnknownScts;

+ m_securityDetails.numInvalidSCTs = numInvalidScts;

+ m_securityDetails.numValidSCTs = numValidScts;

}

void ResourceResponse::setHTTPHeaderField(const AtomicString& name, const AtomicString& value)