Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: third_party/WebKit/public/platform/WebURLResponse.h

Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address latest comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebURLResponse.h
diff --git a/third_party/WebKit/public/platform/WebURLResponse.h b/third_party/WebKit/public/platform/WebURLResponse.h
index 3a64468b936169ac8efcda7da8d12b2f79a6b74f..d3a8c420a435a7b3df325a1b09b2045b060a71d8 100644
--- a/third_party/WebKit/public/platform/WebURLResponse.h
+++ b/third_party/WebKit/public/platform/WebURLResponse.h
@@ -33,6 +33,7 @@
#include "public/platform/WebCommon.h"
#include "public/platform/WebPrivateOwnPtr.h"
+#include "public/platform/WebString.h"
#include "public/platform/modules/serviceworker/WebServiceWorkerResponseType.h"
namespace blink {
@@ -61,6 +62,31 @@ public:
SecurityStyleAuthenticated
};
+ struct WebSecurityDetails {
+ WebSecurityDetails(const WebString& protocol, const WebString& keyExchange, const WebString& cipher, const WebString& mac, int certId, size_t numUnknownScts, size_t numInvalidScts, size_t numValidScts)
+ : protocol(protocol)
+ , keyExchange(keyExchange)
+ , cipher(cipher)
+ , mac(mac)
+ , certId(certId)
+ , numUnknownScts(numUnknownScts)
+ , numInvalidScts(numInvalidScts)
+ , numValidScts(numValidScts)
+ {
+ }
+ // All strings are human-readable values.
+ WebString protocol;
+ WebString keyExchange;
+ WebString cipher;
+ // mac is the empty string when the connection cipher suite does not
+ // have a separate MAC value (i.e. if the cipher suite is AEAD).
+ WebString mac;
+ int certId;
+ size_t numUnknownScts;
+ size_t numInvalidScts;
+ size_t numValidScts;
+ };
+
class ExtraData {
public:
virtual ~ExtraData() { }
@@ -151,7 +177,7 @@ public:
BLINK_PLATFORM_EXPORT SecurityStyle securityStyle() const;
BLINK_PLATFORM_EXPORT void setSecurityStyle(SecurityStyle);
- BLINK_PLATFORM_EXPORT void setSecurityDetails(const WebString& protocol, const WebString& keyExchange, const WebString& cipher, const WebString& mac, int certId);
+ BLINK_PLATFORM_EXPORT void setSecurityDetails(const WebSecurityDetails&);
#if INSIDE_BLINK
BLINK_PLATFORM_EXPORT ResourceResponse& toMutableResourceResponse();

Powered by Google App Engine
This is Rietveld 408576698