Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: third_party/WebKit/Source/platform/network/ResourceResponse.h

Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address latest comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/network/ResourceResponse.h
diff --git a/third_party/WebKit/Source/platform/network/ResourceResponse.h b/third_party/WebKit/Source/platform/network/ResourceResponse.h
index bc3e67c570b3fb8b880faa7680c3b883ac157153..bb4e0924e10aa8a3356f0766526154bcda5b716d 100644
--- a/third_party/WebKit/Source/platform/network/ResourceResponse.h
+++ b/third_party/WebKit/Source/platform/network/ResourceResponse.h
@@ -61,7 +61,13 @@ public:
struct SecurityDetails {
DISALLOW_NEW();
- SecurityDetails() : certID(0) {}
+ SecurityDetails()
+ : certID(0)
+ , numUnknownSCTs(0)
+ , numInvalidSCTs(0)
+ , numValidSCTs(0)
+ {
+ }
// All strings are human-readable values.
String protocol;
String keyExchange;
@@ -70,6 +76,9 @@ public:
// have a separate MAC value (i.e. if the cipher suite is AEAD).
String mac;
int certID;
+ size_t numUnknownSCTs;
+ size_t numInvalidSCTs;
+ size_t numValidSCTs;
};
class ExtraData : public RefCounted<ExtraData> {
@@ -167,7 +176,7 @@ public:
void setSecurityStyle(SecurityStyle securityStyle) { m_securityStyle = securityStyle; }
const SecurityDetails* securityDetails() const { return &m_securityDetails; }
- void setSecurityDetails(const String& protocol, const String& keyExchange, const String& cipher, const String& mac, int certId);
+ void setSecurityDetails(const String& protocol, const String& keyExchange, const String& cipher, const String& mac, int certId, size_t numUnknownScts, size_t numInvalidScts, size_t numValidScts);
long long appCacheID() const { return m_appCacheID; }
void setAppCacheID(long long id) { m_appCacheID = id; }

Powered by Google App Engine
This is Rietveld 408576698