Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address latest comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
index b678592b1d8e501e9c63e55d56f554d6d7047022..33a1673d55be3d88fbf3c5b9f0d87e23ff110309 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
@@ -798,8 +798,8 @@ WebInspector.SecurityOriginView = function(panel, origin, originState)
table.addRow("Valid From", validFromString);
table.addRow("Valid Until", validUntilString);
table.addRow("Issuer", certificateDetails.issuer);
+ table.addRow("SCTs", this.sctSummary(originState.securityDetails.certificateValidationDetails));
table.addRow("", WebInspector.SecurityPanel.createCertificateViewerButton(WebInspector.UIString("Open full certificate details"), originState.securityDetails.certificateId));
- // TODO(lgarron): Make SCT status available in certificate details and show it here.
}
function displayCertificateDetailsUnavailable ()
@@ -879,6 +879,26 @@ WebInspector.SecurityOriginView.prototype = {
this._originLockIcon.classList.add("security-property-" + newSecurityState);
},
+ /**
+ * @constructor
+ * @param {?NetworkAgent.CertificateValidationDetails} details
+ * @return {string}
+ */
+ sctSummary: function(details)
+ {
+ if (!details)
+ return WebInspector.UIString("N/A");
+
+ var sctTypeList = [];
+ if (details.numValidScts)
+ sctTypeList.push(WebInspector.UIString("%d valid SCT%s", details.numValidScts, (details.numValidScts > 1) ? "s" : ""));
+ if (details.numInvalidScts)
+ sctTypeList.push(WebInspector.UIString("%d invalid SCT%s", details.numInvalidScts, (details.numInvalidScts > 1) ? "s" : ""));
+ if (details.numUnknownScts)
+ sctTypeList.push(WebInspector.UIString("%d SCT%s from unknown logs", details.numUnknownScts, (details.numUnknownScts > 1) ? "s" : ""));
+ return sctTypeList.length ? sctTypeList.join(", ") : WebInspector.UIString("0 SCTs");
+ },
+
__proto__: WebInspector.VBox.prototype
}
« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp ('k') | third_party/WebKit/Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698