scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json - Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json

Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Addressed review feedback. Revised tests. Rebased. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json

diff --git a/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json

index b12248b8812fcd29a8c9cd1953b5d7e840f8e97a..67e811efcd65fb19dd5739cfda399ee660d58b76 100644

--- a/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json

+++ b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json

@@ -158,8 +158,19 @@

"@@@STEP_LOG_LINE@json.output@ \"Linux Tests\": {@@@",

"@@@STEP_LOG_LINE@json.output@ \"isolated_scripts\": [@@@",

"@@@STEP_LOG_LINE@json.output@ {@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"args\": [@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"--correct-common-arg\"@@@",

+ "@@@STEP_LOG_LINE@json.output@ ], @@@",

"@@@STEP_LOG_LINE@json.output@ \"isolate_name\": \"telemetry_gpu_unittests\", @@@",

- "@@@STEP_LOG_LINE@json.output@ \"name\": \"telemetry_gpu_unittests\"@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"name\": \"telemetry_gpu_unittests\", @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"non_precommit_args\": [@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"--these-args-should-be-present\", @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"--test-machine-name=\\\"${buildername}\\\"\", @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"--build-revision=\\\"${got_revision}\\\"\"@@@",

+ "@@@STEP_LOG_LINE@json.output@ ], @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"precommit_args\": [@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"--SHOULD-NOT-BE-PRESENT-DURING-THE-RUN\"@@@",

+ "@@@STEP_LOG_LINE@json.output@ ]@@@",

"@@@STEP_LOG_LINE@json.output@ }@@@",

"@@@STEP_LOG_LINE@json.output@ ]@@@",

"@@@STEP_LOG_LINE@json.output@ }@@@",

@@ -246,6 +257,10 @@

"https://isolateserver.appspot.com",

"--verbose",

"--",

+ "--correct-common-arg",

+ "--these-args-should-be-present",

+ "--test-machine-name=\"Linux Tests\"",

+ "--build-revision=\"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"",

"--isolated-script-test-output",

"/path/to/tmp/json"

« no previous file with comments | « scripts/slave/recipes/chromium.py ('k') | scripts/slave/recipes/chromium_gn.py » ('j') | no next file with comments »