Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json

Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Addressed review feedback. Revised tests. Rebased. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « scripts/slave/recipes/chromium.py ('k') | scripts/slave/recipes/chromium_gn.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 [ 1 [
2 { 2 {
3 "cmd": [ 3 "cmd": [
4 "python", 4 "python",
5 "-u", 5 "-u",
6 "[BUILD]/scripts/slave/bot_update.py", 6 "[BUILD]/scripts/slave/bot_update.py",
7 "--master", 7 "--master",
8 "chromium.linux", 8 "chromium.linux",
9 "--builder", 9 "--builder",
10 "Linux Tests", 10 "Linux Tests",
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 "/path/to/tmp/json" 151 "/path/to/tmp/json"
152 ], 152 ],
153 "cwd": "[SLAVE_BUILD]", 153 "cwd": "[SLAVE_BUILD]",
154 "name": "read test spec", 154 "name": "read test spec",
155 "~followup_annotations": [ 155 "~followup_annotations": [
156 "@@@STEP_TEXT@path: [SLAVE_BUILD]/src/testing/buildbot/chromium.linux.json @@@", 156 "@@@STEP_TEXT@path: [SLAVE_BUILD]/src/testing/buildbot/chromium.linux.json @@@",
157 "@@@STEP_LOG_LINE@json.output@{@@@", 157 "@@@STEP_LOG_LINE@json.output@{@@@",
158 "@@@STEP_LOG_LINE@json.output@ \"Linux Tests\": {@@@", 158 "@@@STEP_LOG_LINE@json.output@ \"Linux Tests\": {@@@",
159 "@@@STEP_LOG_LINE@json.output@ \"isolated_scripts\": [@@@", 159 "@@@STEP_LOG_LINE@json.output@ \"isolated_scripts\": [@@@",
160 "@@@STEP_LOG_LINE@json.output@ {@@@", 160 "@@@STEP_LOG_LINE@json.output@ {@@@",
161 "@@@STEP_LOG_LINE@json.output@ \"args\": [@@@",
162 "@@@STEP_LOG_LINE@json.output@ \"--correct-common-arg\"@@@",
163 "@@@STEP_LOG_LINE@json.output@ ], @@@",
161 "@@@STEP_LOG_LINE@json.output@ \"isolate_name\": \"telemetry_gpu_un ittests\", @@@", 164 "@@@STEP_LOG_LINE@json.output@ \"isolate_name\": \"telemetry_gpu_un ittests\", @@@",
162 "@@@STEP_LOG_LINE@json.output@ \"name\": \"telemetry_gpu_unittests\ "@@@", 165 "@@@STEP_LOG_LINE@json.output@ \"name\": \"telemetry_gpu_unittests\ ", @@@",
166 "@@@STEP_LOG_LINE@json.output@ \"non_precommit_args\": [@@@",
167 "@@@STEP_LOG_LINE@json.output@ \"--these-args-should-be-present\" , @@@",
168 "@@@STEP_LOG_LINE@json.output@ \"--test-machine-name=\\\"${builde rname}\\\"\", @@@",
169 "@@@STEP_LOG_LINE@json.output@ \"--build-revision=\\\"${got_revis ion}\\\"\"@@@",
170 "@@@STEP_LOG_LINE@json.output@ ], @@@",
171 "@@@STEP_LOG_LINE@json.output@ \"precommit_args\": [@@@",
172 "@@@STEP_LOG_LINE@json.output@ \"--SHOULD-NOT-BE-PRESENT-DURING-T HE-RUN\"@@@",
173 "@@@STEP_LOG_LINE@json.output@ ]@@@",
163 "@@@STEP_LOG_LINE@json.output@ }@@@", 174 "@@@STEP_LOG_LINE@json.output@ }@@@",
164 "@@@STEP_LOG_LINE@json.output@ ]@@@", 175 "@@@STEP_LOG_LINE@json.output@ ]@@@",
165 "@@@STEP_LOG_LINE@json.output@ }@@@", 176 "@@@STEP_LOG_LINE@json.output@ }@@@",
166 "@@@STEP_LOG_LINE@json.output@}@@@", 177 "@@@STEP_LOG_LINE@json.output@}@@@",
167 "@@@STEP_LOG_END@json.output@@@" 178 "@@@STEP_LOG_END@json.output@@@"
168 ] 179 ]
169 }, 180 },
170 { 181 {
171 "cmd": [ 182 "cmd": [
172 "python", 183 "python",
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 "cmd": [ 250 "cmd": [
240 "python", 251 "python",
241 "-u", 252 "-u",
242 "[SLAVE_BUILD]/src/tools/swarming_client/run_isolated.py", 253 "[SLAVE_BUILD]/src/tools/swarming_client/run_isolated.py",
243 "--isolated", 254 "--isolated",
244 "eeeeeeeeeeeeeeeeeeeeeeeeeeeeee", 255 "eeeeeeeeeeeeeeeeeeeeeeeeeeeeee",
245 "-I", 256 "-I",
246 "https://isolateserver.appspot.com", 257 "https://isolateserver.appspot.com",
247 "--verbose", 258 "--verbose",
248 "--", 259 "--",
260 "--correct-common-arg",
261 "--these-args-should-be-present",
262 "--test-machine-name=\"Linux Tests\"",
263 "--build-revision=\"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"",
249 "--isolated-script-test-output", 264 "--isolated-script-test-output",
250 "/path/to/tmp/json" 265 "/path/to/tmp/json"
251 ], 266 ],
252 "cwd": "[SLAVE_BUILD]", 267 "cwd": "[SLAVE_BUILD]",
253 "name": "telemetry_gpu_unittests", 268 "name": "telemetry_gpu_unittests",
254 "~followup_annotations": [ 269 "~followup_annotations": [
255 "@@@STEP_LOG_LINE@json.output@{@@@", 270 "@@@STEP_LOG_LINE@json.output@{@@@",
256 "@@@STEP_LOG_LINE@json.output@ \"failures\": [], @@@", 271 "@@@STEP_LOG_LINE@json.output@ \"failures\": [], @@@",
257 "@@@STEP_LOG_LINE@json.output@ \"valid\": true@@@", 272 "@@@STEP_LOG_LINE@json.output@ \"valid\": true@@@",
258 "@@@STEP_LOG_LINE@json.output@}@@@", 273 "@@@STEP_LOG_LINE@json.output@}@@@",
259 "@@@STEP_LOG_END@json.output@@@" 274 "@@@STEP_LOG_END@json.output@@@"
260 ] 275 ]
261 }, 276 },
262 { 277 {
263 "name": "$result", 278 "name": "$result",
264 "recipe_result": null, 279 "recipe_result": null,
265 "status_code": 0 280 "status_code": 0
266 } 281 }
267 ] 282 ]
OLDNEW
« no previous file with comments | « scripts/slave/recipes/chromium.py ('k') | scripts/slave/recipes/chromium_gn.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698