scripts/slave/recipes/chromium_gn.py - Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_gn.py

Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Addressed review feedback. Revised tests. Rebased. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json ('k') | scripts/slave/recipes/chromium_trybot.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_gn.py

diff --git a/scripts/slave/recipes/chromium_gn.py b/scripts/slave/recipes/chromium_gn.py

index ce120c12e25d105d5cf098dc95ac7002c55e2737..511ad9956f1859edcdd333f6366837f41414e130 100644

--- a/scripts/slave/recipes/chromium_gn.py

+++ b/scripts/slave/recipes/chromium_gn.py

@@ -134,13 +134,14 @@ def _RunStepsInternal(api):

test_spec = api.chromium_tests.read_test_spec(api, test_spec_file)

tests = list(api.chromium_tests.steps.generate_gtest(

- api, mastername, buildername, test_spec))

+ api, api.chromium_tests, mastername, buildername, test_spec,

+ bot_update_step))

scripts_compile_targets = \

api.chromium_tests.get_compile_targets_for_scripts().json.output

tests += list(api.chromium_tests.steps.generate_script(

- api, mastername, buildername, test_spec,

- scripts_compile_targets=scripts_compile_targets))

+ api, api.chromium_tests, mastername, buildername, test_spec,

+ bot_update_step, scripts_compile_targets=scripts_compile_targets))

additional_compile_targets = test_spec.get(buildername, {}).get(

'additional_compile_targets',