scripts/slave/recipes/chromium.py - Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.py

Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Addressed review feedback. Revised tests. Rebased. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/android/perf.py ('k') | scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.py

diff --git a/scripts/slave/recipes/chromium.py b/scripts/slave/recipes/chromium.py

index 591da88d85916b31f970c747a84844e105fe40df..57fdbca9dee315d9562c19dc9962d2c13180b75b 100644

--- a/scripts/slave/recipes/chromium.py

+++ b/scripts/slave/recipes/chromium.py

@@ -291,7 +291,14 @@ def GenTests(api):

'isolated_scripts': [

{

'isolate_name': 'telemetry_gpu_unittests',

- 'name': 'telemetry_gpu_unittests'

+ 'name': 'telemetry_gpu_unittests',

+ 'args': ['--correct-common-arg'],

+ 'precommit_args': ['--SHOULD-NOT-BE-PRESENT-DURING-THE-RUN'],

+ 'non_precommit_args': [

+ '--these-args-should-be-present',

+ '--test-machine-name=\"${buildername}\"',

+ '--build-revision=\"${got_revision}\"',

+ ],

« no previous file with comments | « scripts/slave/recipes/android/perf.py ('k') | scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json » ('j') | no next file with comments »