Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 158783002: Limit beforeunload returnValue propagation to event handlers. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Limit beforeunload returnValue propagation to event handlers. The required extra handling of the return value from an 'onbeforeunload' event handler, http://www.whatwg.org/specs/web-apps/current-work/#the-event-handler-processing-algorithm (step 4) should not apply to event listeners. R= BUG=341476 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166828

Patch Set 1 #

Patch Set 2 : Switch tests to use onbeforeunload event handlers instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
A + LayoutTests/fast/events/before-unload-return-value-from-listener.html View 1 chunk +9 lines, -8 lines 0 comments Download
A + LayoutTests/fast/events/before-unload-return-value-from-listener-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html View 1 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/inspector-protocol/page/javascriptDialogEvents.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
When you have a moment, please take a look. This will make beforeunload event listeners ...
6 years, 10 months ago (2014-02-10 12:08:35 UTC) #1
haraken
Given the spec and Firefox's behavior, LGTM.
6 years, 10 months ago (2014-02-10 12:13:03 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-10 12:20:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/158783002/40001
6 years, 10 months ago (2014-02-10 12:20:32 UTC) #4
commit-bot: I haz the power
Change committed as 166828
6 years, 10 months ago (2014-02-10 14:25:45 UTC) #5
arv (Not doing code reviews)
6 years, 10 months ago (2014-02-10 14:48:38 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698