LayoutTests/inspector-protocol/page/javascriptDialogEvents.html - Issue 158783002: Limit beforeunload returnValue propagation to event handlers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector-protocol/page/javascriptDialogEvents.html

Issue 158783002: Limit beforeunload returnValue propagation to event handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch tests to use onbeforeunload event handlers instead. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script type="text/javascript" src="../../http/tests/inspector-protocol/resource s/protocol-test.js"></script>	3 <script type="text/javascript" src="../../http/tests/inspector-protocol/resource s/protocol-test.js"></script>

4 <script>	4 <script>

5	5

6 window.addEventListener("beforeunload", onBeforeUnload);	6 window.onbeforeunload = onBeforeUnload;

7	7

8 function onBeforeUnload()	8 function onBeforeUnload()

9 {	9 {

10 window.removeEventListener("beforeunload", onBeforeUnload);	10 window.removeEventListener("beforeunload", onBeforeUnload);

11 return "beforeunload in javascriptDialogEvents";	11 return "beforeunload in javascriptDialogEvents";

12 }	12 }

13	13

14 function test()	14 function test()

15 {	15 {

16 InspectorTest.eventHandler["Page.javascriptDialogOpening"] = onOpening;	16 InspectorTest.eventHandler["Page.javascriptDialogOpening"] = onOpening;

(...skipping 26 matching lines...) Expand all Loading...
43 {	43 {

44 InspectorTest.completeTest();	44 InspectorTest.completeTest();

45 }	45 }

46 }	46 }

47	47

48 </script>	48 </script>

49 </head>	49 </head>

50 <body onload="runTest()">	50 <body onload="runTest()">

51 </body>	51 </body>

52 </html>	52 </html>

OLD	NEW