LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html - Issue 158783002: Limit beforeunload returnValue propagation to event handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html

Issue 158783002: Limit beforeunload returnValue propagation to event handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch tests to use onbeforeunload event handlers instead. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/before-unload-return-value-from-listener-expected.txt ('k') | LayoutTests/inspector-protocol/page/javascriptDialogEvents.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html

diff --git a/LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html b/LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html

index 48d56e10922c3a6d7ce3daf2638c6225ecb7aedb..692583f6325afef36481d49fab8e4417e4e7ef3a 100644

--- a/LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html

+++ b/LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html

@@ -7,7 +7,7 @@ if (window.testRunner) {

_confirmationDialogDisplayedOnce = false;

-window.addEventListener("beforeunload", function() {

+window.onbeforeunload = function() {

if (window._confirmationDialogDisplayedOnce)

return "Click 'Leave Page'";

@@ -24,11 +24,11 @@ window.addEventListener("beforeunload", function() {

document.forms[0].submit();

}, 0);

window._confirmationDialogDisplayedOnce = true;

return "Click 'Stay on Page'";

-});

+};

</script>

<p>This tests that submitting a form a second time after canceling the first submission in a onbeforeunload handler is allowed. To test manually, follow the instructions in the JavaScript confirmation dialogs.</p>

@@ -40,4 +40,4 @@ window.addEventListener("beforeunload", function() {

document.forms[0].submit();

-</script>

+</script>