Source/bindings/v8/V8AbstractEventListener.cpp - Issue 158783002: Limit beforeunload returnValue propagation to event handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8AbstractEventListener.cpp

Issue 158783002: Limit beforeunload returnValue propagation to event handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch tests to use onbeforeunload event handlers instead. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/V8AbstractEventListener.cpp

diff --git a/Source/bindings/v8/V8AbstractEventListener.cpp b/Source/bindings/v8/V8AbstractEventListener.cpp

index 0f9c40504aa65393eeefe4cf286a05477e12d8e7..c1505fd7c52751082bd4008b96cb35a696e07b88 100644

--- a/Source/bindings/v8/V8AbstractEventListener.cpp

+++ b/Source/bindings/v8/V8AbstractEventListener.cpp

@@ -149,7 +149,7 @@ void V8AbstractEventListener::invokeEventHandler(ExecutionContext* context, Even

if (returnValue.IsEmpty())

return;

- if (!returnValue->IsNull() && !returnValue->IsUndefined() && event->isBeforeUnloadEvent()) {

+ if (m_isAttribute && !returnValue->IsNull() && !returnValue->IsUndefined() && event->isBeforeUnloadEvent()) {

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, stringReturnValue, returnValue);

toBeforeUnloadEvent(event)->setReturnValue(stringReturnValue);

}

« no previous file with comments | « LayoutTests/inspector-protocol/page/javascriptDialogEvents.html ('k') | no next file » | no next file with comments »