Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously (Closed)

Created:
7 years, 6 months ago by not at google - send to devlin
Modified:
7 years, 4 months ago
Reviewers:
CC:
chromium-reviews, vsevik, nkostylev+watch_chromium.org, yurys, Aaron Boodman, rginda+watch_chromium.org, pfeldman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Make miscellaneous_bindings and event_bindings Required as needed. Previously they needed to be included when each context starts. BUG=55316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+841 lines, -704 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_handler_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/extension_message_port.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/extension_message_port.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_port.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_port.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 3 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 4 chunks +26 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/app_window_contents.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/event_router.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/message_handler.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/message_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/test.json View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.h View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.cc View 9 chunks +23 lines, -63 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context_set.h View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context_set.cc View 4 chunks +4 lines, -23 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.h View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 19 chunks +71 lines, -26 lines 0 comments Download
M chrome/renderer/extensions/event_unittest.cc View 11 chunks +30 lines, -40 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 4 chunks +15 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.cc View 6 chunks +89 lines, -67 lines 0 comments Download
M chrome/renderer/extensions/module_system.h View 6 chunks +21 lines, -7 lines 0 comments Download
M chrome/renderer/extensions/module_system.cc View 9 chunks +66 lines, -43 lines 0 comments Download
M chrome/renderer/extensions/module_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/app_custom_bindings.js View 3 chunks +12 lines, -13 lines 0 comments Download
M chrome/renderer/resources/extensions/app_runtime_custom_bindings.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/app_window_custom_bindings.js View 7 chunks +20 lines, -15 lines 0 comments Download
M chrome/renderer/resources/extensions/binding.js View 4 chunks +7 lines, -11 lines 0 comments Download
M chrome/renderer/resources/extensions/bluetooth_custom_bindings.js View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/chrome_setting.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/context_menus_custom_bindings.js View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/downloads_custom_bindings.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/event.js View 17 chunks +37 lines, -60 lines 0 comments Download
M chrome/renderer/resources/extensions/extension_custom_bindings.js View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/input.ime_custom_bindings.js View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/miscellaneous_bindings.js View 8 chunks +122 lines, -132 lines 0 comments Download
M chrome/renderer/resources/extensions/omnibox_custom_bindings.js View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/renderer/resources/extensions/on_unload.js View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/page_actions_custom_bindings.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/permissions_custom_bindings.js View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/runtime_custom_bindings.js View 6 chunks +17 lines, -17 lines 0 comments Download
M chrome/renderer/resources/extensions/schema_utils.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/send_request.js View 6 chunks +15 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/sync_file_system_custom_bindings.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/system_indicator_custom_bindings.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/tabs_custom_bindings.js View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/renderer/resources/extensions/test_custom_bindings.js View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/tts_engine_custom_bindings.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/web_request_custom_bindings.js View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/webstore_custom_bindings.js View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/module_system_test.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/test/data/devtools/extensions/devtools_messaging/devtools.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/events/background.js View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698