chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js - Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js

Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/extension_custom_bindings.js ('k') | chrome/renderer/resources/extensions/input.ime_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js b/chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js

index 1fbe7b08c00e549c3373f1c56510efb1edf6b78a..af310bae4b47c5d8e90159b77c2e9f8180d2c370 100644

--- a/chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js

@@ -6,14 +6,13 @@

var binding = require('binding').Binding.create('fileBrowserHandler');

+var eventBindings = require('event_bindings');

var fileBrowserNatives = requireNative('file_browser_handler');

var GetExternalFileEntry = fileBrowserNatives.GetExternalFileEntry;

-var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

var fileBrowserHandlerInternal = require('binding').Binding.create(

'fileBrowserHandlerInternal').generate();

-chromeHidden.Event.registerArgumentMassager('fileBrowserHandler.onExecute',

+eventBindings.registerArgumentMassager('fileBrowserHandler.onExecute',

function(args, dispatch) {

if (args.length < 2) {

dispatch(args);