chrome/renderer/resources/extensions/downloads_custom_bindings.js - Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/downloads_custom_bindings.js

Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/context_menus_custom_bindings.js ('k') | chrome/renderer/resources/extensions/event.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/downloads_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/downloads_custom_bindings.js b/chrome/renderer/resources/extensions/downloads_custom_bindings.js

index 36832f62bb840fd825dbc757ea682821482cebf6..be7d1c42cbd23248b6ee856e1e09d1e92b18c655 100644

--- a/chrome/renderer/resources/extensions/downloads_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/downloads_custom_bindings.js

@@ -5,11 +5,11 @@

// Custom bindings for the downloads API.

var binding = require('binding').Binding.create('downloads');

-var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

var downloadsInternal = require('binding').Binding.create(

'downloadsInternal').generate();

+var eventBindings = require('event_bindings');

-chromeHidden.Event.registerArgumentMassager(

+eventBindings.registerArgumentMassager(

'downloads.onDeterminingFilename',

function massage_determining_filename(args, dispatch) {

var downloadItem = args[0];