chrome/renderer/resources/extensions/page_actions_custom_bindings.js - Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/page_actions_custom_bindings.js

Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/on_unload.js ('k') | chrome/renderer/resources/extensions/permissions_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/page_actions_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/page_actions_custom_bindings.js b/chrome/renderer/resources/extensions/page_actions_custom_bindings.js

index 0b72e0717530b6fe3f461281e1d445c5ac656c30..2f1b9a18ead3beeebd6da94345162192baff7557 100644

--- a/chrome/renderer/resources/extensions/page_actions_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/page_actions_custom_bindings.js

@@ -6,16 +6,16 @@

var binding = require('binding').Binding.create('pageActions');

+var Event = require('event_bindings').Event;

var pageActionsNatives = requireNative('page_actions');

-var GetCurrentPageActions = pageActionsNatives.GetCurrentPageActions;

binding.registerCustomHook(function(bindingsAPI, extensionId) {

- var pageActions = GetCurrentPageActions(extensionId);

+ var pageActions = pageActionsNatives.GetCurrentPageActions(extensionId);

var pageActionsApi = bindingsAPI.compiledApi;

var oldStyleEventName = 'pageActions';

for (var i = 0; i < pageActions.length; ++i) {

// Setup events for each extension_id/page_action_id string we find.

- pageActionsApi[pageActions[i]] = new chrome.Event(oldStyleEventName);

+ pageActionsApi[pageActions[i]] = new Event(oldStyleEventName);

}

});