Issue 15817014: remove most uses of raw handle constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15817014: remove most uses of raw handle constructors (Closed)

Created:
7 years, 6 months ago by dcarney

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

remove most uses of raw handle constructors R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15107

Patch Set 1 #

Patch Set 2 : missed something #

Patch Set 3 : had to add back some friends #

Patch Set 4 : cleanup, added test-api #

Patch Set 5 : stupid cast needed #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+262 lines, -253 lines)			Patch
M	include/v8.h	View	1 2	11 chunks	+18 lines, -34 lines	0 comments	Download
M	src/api.h	View		2 chunks	+30 lines, -17 lines	0 comments	Download
M	src/api.cc	View		28 chunks	+53 lines, -54 lines	0 comments	Download
M	src/arguments.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/d8.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/d8-debug.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/debug.cc	View		5 chunks	+7 lines, -6 lines	0 comments	Download
M	src/handles.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mksnapshot.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/profile-generator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	src/v8.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/cctest/cctest.h	View	1 2 3	3 chunks	+15 lines, -15 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 2 3 4	17 chunks	+71 lines, -62 lines	0 comments	Download
M	test/cctest/test-debug.cc	View		5 chunks	+7 lines, -6 lines	0 comments	Download
M	test/cctest/test-declarative-accessors.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-global-object.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-log.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/test-object-observe.cc	View	1 2 3	13 chunks	+16 lines, -16 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-weaktypedarrays.cc	View		5 chunks	+22 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dcarney

7 years, 6 months ago (2013-06-13 09:27:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r15107 (presubmit successful).

Expand Messages | Collapse Messages