Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: test/cctest/test-declarative-accessors.cc

Issue 15817014: remove most uses of raw handle constructors (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: stupid cast needed Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/cctest/test-global-object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 static void VerifyRead(v8::Handle<v8::DeclaredAccessorDescriptor> descriptor, 113 static void VerifyRead(v8::Handle<v8::DeclaredAccessorDescriptor> descriptor,
114 int internal_field, 114 int internal_field,
115 void* internal_object, 115 void* internal_object,
116 v8::Handle<v8::Value> expected_value) { 116 v8::Handle<v8::Value> expected_value) {
117 LocalContext local_context; 117 LocalContext local_context;
118 v8::HandleScope scope(local_context->GetIsolate()); 118 v8::HandleScope scope(local_context->GetIsolate());
119 v8::Handle<v8::Context> context = local_context.local(); 119 v8::Handle<v8::Context> context = local_context.local();
120 CreateConstructor(context, "Accessible", internal_field, "x", descriptor); 120 CreateConstructor(context, "Accessible", internal_field, "x", descriptor);
121 // Setup object. 121 // Setup object.
122 CompileRun("var accessible = new Accessible();"); 122 CompileRun("var accessible = new Accessible();");
123 v8::Local<v8::Object> obj( 123 v8::Local<v8::Object> obj = v8::Local<v8::Object>::Cast(
124 v8::Object::Cast(*context->Global()->Get(v8_str("accessible")))); 124 context->Global()->Get(v8_str("accessible")));
125 obj->SetAlignedPointerInInternalField(internal_field, internal_object); 125 obj->SetAlignedPointerInInternalField(internal_field, internal_object);
126 bool added_accessor; 126 bool added_accessor;
127 added_accessor = obj->SetAccessor(v8_str("y"), descriptor); 127 added_accessor = obj->SetAccessor(v8_str("y"), descriptor);
128 CHECK(added_accessor); 128 CHECK(added_accessor);
129 added_accessor = obj->SetAccessor(v8_str("13"), descriptor); 129 added_accessor = obj->SetAccessor(v8_str("13"), descriptor);
130 CHECK(added_accessor); 130 CHECK(added_accessor);
131 // Test access from template getter. 131 // Test access from template getter.
132 v8::Local<v8::Value> value; 132 v8::Local<v8::Value> value;
133 value = CompileRun("accessible.x;"); 133 value = CompileRun("accessible.x;");
134 CHECK_EQ(expected_value, value); 134 CHECK_EQ(expected_value, value);
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 int internal_field = 0; 291 int internal_field = 0;
292 v8::Handle<v8::DeclaredAccessorDescriptor> descriptor = 292 v8::Handle<v8::DeclaredAccessorDescriptor> descriptor =
293 OOD::NewInternalFieldDereference(helper.isolate_, internal_field) 293 OOD::NewInternalFieldDereference(helper.isolate_, internal_field)
294 ->NewRawShift(helper.isolate_, index*kPointerSize) 294 ->NewRawShift(helper.isolate_, index*kPointerSize)
295 ->NewHandleDereference(helper.isolate_); 295 ->NewHandleDereference(helper.isolate_);
296 HandleArray* array = *helper.handle_array_; 296 HandleArray* array = *helper.handle_array_;
297 v8::Handle<v8::String> expected = v8_str("whatever"); 297 v8::Handle<v8::String> expected = v8_str("whatever");
298 array->handles_[index].Reset(helper.isolate_, expected); 298 array->handles_[index].Reset(helper.isolate_, expected);
299 VerifyRead(descriptor, internal_field, array, expected); 299 VerifyRead(descriptor, internal_field, array, expected);
300 } 300 }
OLDNEW
« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/cctest/test-global-object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698