Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Side by Side Diff: src/log.cc

Issue 15817014: remove most uses of raw handle constructors (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: stupid cast needed Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.cc ('k') | src/mksnapshot.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 Script* script, 428 Script* script,
429 const char* name, 429 const char* name,
430 size_t name_len) { 430 size_t name_len) {
431 JitCodeEvent event; 431 JitCodeEvent event;
432 memset(&event, 0, sizeof(event)); 432 memset(&event, 0, sizeof(event));
433 event.type = JitCodeEvent::CODE_ADDED; 433 event.type = JitCodeEvent::CODE_ADDED;
434 event.code_start = code->instruction_start(); 434 event.code_start = code->instruction_start();
435 event.code_len = code->instruction_size(); 435 event.code_len = code->instruction_size();
436 Handle<Script> script_handle = 436 Handle<Script> script_handle =
437 script != NULL ? Handle<Script>(script) : Handle<Script>(); 437 script != NULL ? Handle<Script>(script) : Handle<Script>();
438 event.script = v8::Handle<v8::Script>(ToApi<v8::Script>(script_handle)); 438 event.script = ToApiHandle<v8::Script>(script_handle);
439 event.name.str = name; 439 event.name.str = name;
440 event.name.len = name_len; 440 event.name.len = name_len;
441 441
442 code_event_handler_(&event); 442 code_event_handler_(&event);
443 } 443 }
444 444
445 445
446 void Logger::IssueCodeMovedEvent(Address from, Address to) { 446 void Logger::IssueCodeMovedEvent(Address from, Address to) {
447 Code* from_code = Code::cast(HeapObject::FromAddress(from)); 447 Code* from_code = Code::cast(HeapObject::FromAddress(from));
448 448
(...skipping 1443 matching lines...) Expand 10 before | Expand all | Expand 10 after
1892 profiler_ = NULL; 1892 profiler_ = NULL;
1893 } 1893 }
1894 1894
1895 delete ticker_; 1895 delete ticker_;
1896 ticker_ = NULL; 1896 ticker_ = NULL;
1897 1897
1898 return log_->Close(); 1898 return log_->Close();
1899 } 1899 }
1900 1900
1901 } } // namespace v8::internal 1901 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/handles.cc ('k') | src/mksnapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698