src/handles.cc - Issue 15817014: remove most uses of raw handle constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles.cc

Issue 15817014: remove most uses of raw handle constructors (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: stupid cast needed Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/handles.cc

diff --git a/src/handles.cc b/src/handles.cc

index 658bb2a2a24937d2b833e1411b9b7f413cf166fb..152f8c2531b9387d042839bf0269e37847085cb8 100644

--- a/src/handles.cc

+++ b/src/handles.cc

@@ -347,7 +347,7 @@ Handle<Object> SetAccessor(Handle<JSObject> obj, Handle<AccessorInfo> info) {

static void ClearWrapperCache(v8::Isolate* v8_isolate,

Persistent<v8::Value>* handle,

void*) {

- Handle<Object> cache = Utils::OpenHandle(**handle);

+ Handle<Object> cache = Utils::OpenPersistent(handle);

JSValue* wrapper = JSValue::cast(*cache);

Foreign* foreign = Script::cast(wrapper->value())->wrapper();

ASSERT(foreign->foreign_address() ==

« no previous file with comments | « src/debug.cc ('k') | src/log.cc » ('j') | no next file with comments »