Restrict GeneratePreagedPrologue to proper functions.

Restrict GeneratePreagedPrologue to proper functions.

This solves a bug discovered with fast accessors, where a pre-age prologue
was written into a stub. Since StaticMarkingVisitor<.>::IsFlushable will
only flush Code::FUNCTION [1], we'll restrict GeneratePreagedPrologue to
functions, too, instead of adding a Code::STUB restriction.

Also, generalize api accessor test cases to --optimize-for-size.
Also, fix CompilationCacheCachingBehavior for --optimize-for-size.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/heap/objects-visiting-inl.h&l=629-632

R=epertoso
BUG=

Committed: https://crrev.com/41719a42ac105963c1709e0c6117caea68aaaef8
Cr-Commit-Position: refs/heads/master@{#33291}

[vogelheim, 2016-01-13 15:48:51]

vogelheim@chromium.org changed reviewers:
+ verwaest@chromium.org

[vogelheim, 2016-01-13 15:48:52]

Toon, would you be the right person to review the
CompilationCacheCachingBehavior test?

[epertoso, 2016-01-13 15:52:48]

lgtm

[jochen (gone - plz use gerrit), 2016-01-14 10:58:37]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-01-14 10:58:37]

lgtm

[vogelheim, 2016-01-14 11:27:11]

The CQ bit was checked by vogelheim@chromium.org

[vogelheim, 2016-01-14 11:27:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
epertoso@chromium.org
Link to the patchset: https://codereview.chromium.org/1580323003/#ps20001
(title: "Fix CompilationCacheCachingBehavior for all combinations of --age-code
and --optimize-for-size.")

[commit-bot: I haz the power, 2016-01-14 11:27:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580323003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580323003/20001

[commit-bot: I haz the power, 2016-01-14 11:48:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-14 11:48:22]

Description was changed from

==========
Restrict GeneratePreagedPrologue to proper functions.

This solves a bug discovered with fast accessors, where a pre-age prologue
was written into a stub. Since StaticMarkingVisitor<.>::IsFlushable will
only flush Code::FUNCTION [1], we'll restrict GeneratePreagedPrologue to
functions, too, instead of adding a Code::STUB restriction.

Also, generalize api accessor test cases to --optimize-for-size.
Also, fix CompilationCacheCachingBehavior for --optimize-for-size.


[1]
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/heap/object...

R=epertoso
BUG=
==========

to

==========
Restrict GeneratePreagedPrologue to proper functions.

This solves a bug discovered with fast accessors, where a pre-age prologue
was written into a stub. Since StaticMarkingVisitor<.>::IsFlushable will
only flush Code::FUNCTION [1], we'll restrict GeneratePreagedPrologue to
functions, too, instead of adding a Code::STUB restriction.

Also, generalize api accessor test cases to --optimize-for-size.
Also, fix CompilationCacheCachingBehavior for --optimize-for-size.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/heap/object...

R=epertoso
BUG=

Committed: https://crrev.com/41719a42ac105963c1709e0c6117caea68aaaef8
Cr-Commit-Position: refs/heads/master@{#33291}
==========

[commit-bot: I haz the power, 2016-01-14 11:48:23]

Patchset 2 (id:??) landed as
https://crrev.com/41719a42ac105963c1709e0c6117caea68aaaef8
Cr-Commit-Position: refs/heads/master@{#33291}