Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: test/cctest/test-api-fast-accessor-builder.cc

Issue 1580323003: Restrict GeneratePreagedPrologue to proper functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix CompilationCacheCachingBehavior for all combinations of --age-code and --optimize-for-size. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api-accessors.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api-fast-accessor-builder.cc
diff --git a/test/cctest/test-api-fast-accessor-builder.cc b/test/cctest/test-api-fast-accessor-builder.cc
index a6f1a4229be0e5db489569f6c6c87848ad779d64..3b38c66a598d95cc92783f4f458f3d9f8eebf58f 100644
--- a/test/cctest/test-api-fast-accessor-builder.cc
+++ b/test/cctest/test-api-fast-accessor-builder.cc
@@ -38,7 +38,7 @@ static void NativePropertyAccessor(
// Build a simple "fast accessor" and verify that it is being called.
TEST(FastAccessor) {
- if (i::FLAG_always_opt || i::FLAG_optimize_for_size) return;
+ if (i::FLAG_always_opt) return;
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
@@ -88,7 +88,7 @@ void AddInternalFieldAccessor(v8::Isolate* isolate,
// "Fast" accessor that accesses an internal field.
TEST(FastAccessorWithInternalField) {
- if (i::FLAG_always_opt || i::FLAG_optimize_for_size) return;
+ if (i::FLAG_always_opt) return;
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
@@ -120,7 +120,7 @@ TEST(FastAccessorWithInternalField) {
// "Fast" accessor with control flow via ...OrReturnNull methods.
TEST(FastAccessorOrReturnNull) {
- if (i::FLAG_always_opt || i::FLAG_optimize_for_size) return;
+ if (i::FLAG_always_opt) return;
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
@@ -173,7 +173,7 @@ TEST(FastAccessorOrReturnNull) {
// "Fast" accessor with simple control flow via explicit labels.
TEST(FastAccessorControlFlowWithLabels) {
- if (i::FLAG_always_opt || i::FLAG_optimize_for_size) return;
+ if (i::FLAG_always_opt) return;
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
@@ -210,7 +210,7 @@ TEST(FastAccessorControlFlowWithLabels) {
// "Fast" accessor, loading things.
TEST(FastAccessorLoad) {
- if (i::FLAG_always_opt || i::FLAG_optimize_for_size) return;
+ if (i::FLAG_always_opt) return;
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
« no previous file with comments | « test/cctest/test-api-accessors.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698