Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/compiler.h

Issue 1580323003: Restrict GeneratePreagedPrologue to proper functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix CompilationCacheCachingBehavior for all combinations of --age-code and --optimize-for-size. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.h
diff --git a/src/compiler.h b/src/compiler.h
index 8aefe9205a90ca0bfe4059fdafbe2418900810c7..9b439397c3c18f25503787d7476edff9ca95ec56 100644
--- a/src/compiler.h
+++ b/src/compiler.h
@@ -270,10 +270,10 @@ class CompilationInfo {
bool GeneratePreagedPrologue() const {
// Generate a pre-aged prologue if we are optimizing for size, which
- // will make code flushing more aggressive. The code for WASM functions
- // cannot be flushed, so it does not make sense to age them.
+ // will make code flushing more aggressive. Only apply to Code::FUNCTION,
+ // since StaticMarkingVisitor::IsFlushable only flushes proper functions.
return FLAG_optimize_for_size && FLAG_age_code && !will_serialize() &&
- !is_debug() && output_code_kind_ != Code::WASM_FUNCTION;
+ !is_debug() && output_code_kind_ == Code::FUNCTION;
}
void EnsureFeedbackVector();
« no previous file with comments | « no previous file | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698