V8 Buildbot: Switch static-initializer check to swarming.

scripts/slave/recipe_modules/v8/testing.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 from recipe_engine.types import freeze
 
 
 TEST_CONFIGS = freeze({
   'benchmarks': {
@@ skipping 333 matching lines @@
 class V8Presubmit(BaseTest):
   def run(self, **kwargs):
     self.api.python(
       'Presubmit',
       self.api.path['checkout'].join('tools', 'presubmit.py'),
       cwd=self.api.path['checkout'],
     )
     return TestResults.empty()
 
 
 class V8CheckInitializers(BaseTest):

[Michael Achenbach, 2016/01/11 08:37:42]

No point keeping the non-swarming version for anything, I guess. It wouldn't be
covered now anyways...

[tandrii(chromium), 2016/01/11 08:39:52]

Acknowledged.

-  def run(self, **kwargs):
-    self.api.step(
-      'Static-Initializers',
-      ['bash',
-       self.api.path['checkout'].join('tools', 'check-static-initializers.sh'),
-       self.api.path.join(
-           self.api.path.basename(self.api.chromium.c.build_dir),
-           self.api.chromium.c.build_config_fs,
-           'd8'),
-      ],
-      cwd=self.api.path['checkout'],
-    )
-    return TestResults.empty()
-
-
-class V8CheckInitializersSwarming(BaseTest):
   @property
   def uses_swarming(self):
     """Returns true if the test uses swarming."""
     return True
 
   def pre_run(self, test=None, **kwargs):
     self.test = test or TEST_CONFIGS[self.name]
     self.task = self.api.swarming.task(
         title='Static-Initializers',
         isolated_hash=self._get_isolated_hash(self.test),
         extra_args=[
           self.api.path.join(
               self.api.path.basename(self.api.chromium.c.build_dir),
               self.api.chromium.c.build_config_fs,
               'd8'),
         ],
     )
+    # Set default value.
+    # TODO(machenbach): Merge this code with other swarming tests.
+    if 'os' not in self.task.dimensions:
+      self.task.dimensions['os'] = self.api.swarming.prefered_os_dimension(
+          self.api.platform.name)
     self.api.swarming.trigger_task(self.task)
 
   def run(self, **kwargs):
     assert self.task
     self.api.swarming.collect_task(self.task)
     return TestResults.empty()
 
 
 class V8Fuzzer(BaseTest):
   def run(self, **kwargs):
@@ skipping 96 matching lines @@
 V8_NON_STANDARD_TESTS = freeze({
   'deopt': V8DeoptFuzzer,
   'fuzz': V8Fuzzer,
   'gcmole': V8GCMole,
   'presubmit': V8Presubmit,
   'simpleleak': V8SimpleLeakCheck,
 })
 
 
 TOOL_TO_TEST = freeze({
-  'check-static-initializers': V8CheckInitializers,
   'run-tests': V8Test,
 })
 
 
 TOOL_TO_TEST_SWARMING = freeze({
-  'check-static-initializers': V8CheckInitializersSwarming,
+  'check-static-initializers': V8CheckInitializers,
   'run-tests': V8SwarmingTest,
 })
 
 
 class Failure(object):
   def __init__(self, test_step_config, failure_dict, duration):
     self.test_step_config = test_step_config
     self.failure_dict = failure_dict
     self.duration = duration
 
@@ skipping 32 matching lines @@
     # TODO(machenbach): Implement swarming for non-standard tests.
     if v8_api.bot_config.get('enable_swarming') and test_step_config.swarming:
       tools_mapping = TOOL_TO_TEST_SWARMING
     else:
       tools_mapping = TOOL_TO_TEST
 
     # The tool the test is going to use. Default: V8 test runner (run-tests).
     tool = TEST_CONFIGS[test_step_config.name].get('tool', 'run-tests')
     test_cls = tools_mapping[tool]
   return test_cls(test_step_config, api, v8_api)