Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: scripts/slave/recipe_modules/v8/testing.py

Issue 1578703002: V8 Buildbot: Switch static-initializer check to swarming. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/v8/testing.py
diff --git a/scripts/slave/recipe_modules/v8/testing.py b/scripts/slave/recipe_modules/v8/testing.py
index 0bbfb77c7df0bbda9d0374115f54122de6f56ac0..82dde61d338560cf77260b66afaaaa5f63904f99 100644
--- a/scripts/slave/recipe_modules/v8/testing.py
+++ b/scripts/slave/recipe_modules/v8/testing.py
@@ -352,22 +352,6 @@ class V8Presubmit(BaseTest):
class V8CheckInitializers(BaseTest):
Michael Achenbach 2016/01/11 08:37:42 No point keeping the non-swarming version for anyt
tandrii(chromium) 2016/01/11 08:39:52 Acknowledged.
- def run(self, **kwargs):
- self.api.step(
- 'Static-Initializers',
- ['bash',
- self.api.path['checkout'].join('tools', 'check-static-initializers.sh'),
- self.api.path.join(
- self.api.path.basename(self.api.chromium.c.build_dir),
- self.api.chromium.c.build_config_fs,
- 'd8'),
- ],
- cwd=self.api.path['checkout'],
- )
- return TestResults.empty()
-
-
-class V8CheckInitializersSwarming(BaseTest):
@property
def uses_swarming(self):
"""Returns true if the test uses swarming."""
@@ -385,6 +369,11 @@ class V8CheckInitializersSwarming(BaseTest):
'd8'),
],
)
+ # Set default value.
+ # TODO(machenbach): Merge this code with other swarming tests.
+ if 'os' not in self.task.dimensions:
+ self.task.dimensions['os'] = self.api.swarming.prefered_os_dimension(
+ self.api.platform.name)
self.api.swarming.trigger_task(self.task)
def run(self, **kwargs):
@@ -501,13 +490,12 @@ V8_NON_STANDARD_TESTS = freeze({
TOOL_TO_TEST = freeze({
- 'check-static-initializers': V8CheckInitializers,
'run-tests': V8Test,
})
TOOL_TO_TEST_SWARMING = freeze({
- 'check-static-initializers': V8CheckInitializersSwarming,
+ 'check-static-initializers': V8CheckInitializers,
'run-tests': V8SwarmingTest,
})

Powered by Google App Engine
This is Rietveld 408576698