Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1920)

Side by Side Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1578703002: V8 Buildbot: Switch static-initializer check to swarming. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import argparse 5 import argparse
6 import collections 6 import collections
7 import datetime 7 import datetime
8 import math 8 import math
9 import re 9 import re
10 import urllib 10 import urllib
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 @property 270 @property
271 def perf_tests(self): 271 def perf_tests(self):
272 return self.bot_config.get('perf', []) 272 return self.bot_config.get('perf', [])
273 273
274 def isolate_tests(self): 274 def isolate_tests(self):
275 if self.bot_config.get('enable_swarming'): 275 if self.bot_config.get('enable_swarming'):
276 buildername = self.m.properties['buildername'] 276 buildername = self.m.properties['buildername']
277 tests_to_isolate = [] 277 tests_to_isolate = []
278 def add_tests_to_isolate(tests): 278 def add_tests_to_isolate(tests):
279 for test in tests: 279 for test in tests:
280 if not test.swarming: 280 if not test.swarming: # pragma: no cover
Michael Achenbach 2016/01/11 08:37:42 I'll keep this code around for the next test type
281 # Skip tests that explicitly disable swarming. 281 # Skip tests that explicitly disable swarming.
282 continue 282 continue
283 config = testing.TEST_CONFIGS.get(test.name) or {} 283 config = testing.TEST_CONFIGS.get(test.name) or {}
284 284
285 # Tests either define an explicit isolate target or use the test 285 # Tests either define an explicit isolate target or use the test
286 # names for convenience. 286 # names for convenience.
287 if config.get('isolated_target'): 287 if config.get('isolated_target'):
288 tests_to_isolate.append(config['isolated_target']) 288 tests_to_isolate.append(config['isolated_target'])
289 elif config.get('tests'): 289 elif config.get('tests'):
290 tests_to_isolate.extend(config['tests']) 290 tests_to_isolate.extend(config['tests'])
(...skipping 948 matching lines...) Expand 10 before | Expand all | Expand 10 after
1239 def report_culprits(self, culprit_range): 1239 def report_culprits(self, culprit_range):
1240 assert culprit_range 1240 assert culprit_range
1241 if len(culprit_range) > 1: 1241 if len(culprit_range) > 1:
1242 text = 'Suspecting multiple commits' 1242 text = 'Suspecting multiple commits'
1243 else: 1243 else:
1244 text = 'Suspecting %s' % culprit_range[0][:8] 1244 text = 'Suspecting %s' % culprit_range[0][:8]
1245 1245
1246 step_result = self.m.step(text, cmd=None) 1246 step_result = self.m.step(text, cmd=None)
1247 for culprit in culprit_range: 1247 for culprit in culprit_range:
1248 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit 1248 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/builders.py » ('j') | scripts/slave/recipe_modules/v8/testing.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698