Issue 15742009: expand SkLua to handle creation of its own State

Issue 15742009: expand SkLua to handle creation of its own State (Closed)

Created:
7 years, 7 months ago by reed1

Modified:
7 years, 7 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

expand SkLua to handle creation of its own State add lua sample BUG= R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9247

Patch Set 4 : #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+240 lines, -84 lines)			Patch
M	gyp/SampleApp.gyp	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	include/utils/SkLua.h	View		4 chunks	+13 lines, -5 lines	0 comments	Download
A	samplecode/SampleLua.cpp	View	1 2 3	1 chunk	+110 lines, -0 lines	0 comments	Download
M	src/utils/SkLua.cpp	View	1 2	7 chunks	+107 lines, -32 lines	1 comment	Download
M	src/utils/SkLuaCanvas.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/lua/lua_pictures.cpp	View		3 chunks	+3 lines, -46 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + questions & cleanup https://codereview.chromium.org/15742009/diff/2001/samplecode/SampleLua.cpp File samplecode/SampleLua.cpp (right): https://codereview.chromium.org/15742009/diff/2001/samplecode/SampleLua.cpp#newcode12 samplecode/SampleLua.cpp:12: #include "SkPath.h" Why include ...

7 years, 7 months ago (2013-05-22 19:25:06 UTC) #3

reed1

https://codereview.chromium.org/15742009/diff/2001/samplecode/SampleLua.cpp File samplecode/SampleLua.cpp (right): https://codereview.chromium.org/15742009/diff/2001/samplecode/SampleLua.cpp#newcode12 samplecode/SampleLua.cpp:12: #include "SkPath.h" On 2013/05/22 19:25:06, robertphillips wrote: > Why ...

7 years, 7 months ago (2013-05-22 19:30:59 UTC) #4

robertphillips

https://codereview.chromium.org/15742009/diff/9001/src/utils/SkLua.cpp File src/utils/SkLua.cpp (right): https://codereview.chromium.org/15742009/diff/9001/src/utils/SkLua.cpp#newcode22 src/utils/SkLua.cpp:22: template <typename T> const char* get_mtname(); This is still ...

7 years, 7 months ago (2013-05-22 20:12:35 UTC) #7

reed1

7 years, 7 months ago (2013-05-22 20:12:57 UTC) #8

Message was sent while issue was closed.

Committed patchset #4 manually as r9247 (presubmit successful).

Expand Messages | Collapse Messages