Follow up to https://codereview.chromium.org/1581473002 for Metro removal in installer

Follow up to https://codereview.chromium.org/1581473002 for Metro removal in installer

Removes ShellUtil::ShortcutProperties' |dual_mode| property.

R=gab@chromium.org
BUG=558054
Committed: https://crrev.com/0f4f8338641c6a7a0dc50e0b528f3ade27af0263
Cr-Commit-Position: refs/heads/master@{#369499}

[gab, 2016-01-14 03:22:17]

Please add a note to the CL description to mention it is cleaning up
ShellUtil::ShortcutProperties' |dual_mode| field (so that we can easily find it
from the Metro-removal-meta-bug if we want to bring back dual_mode for whatever
reason in the future).

Otherwise lgtm w/ one more request

Thanks,
Gab

https://codereview.chromium.org/1573243010/diff/20001/chrome/installer/util/s...
File chrome/installer/util/shell_util.cc (left):

https://codereview.chromium.org/1573243010/diff/20001/chrome/installer/util/s...
chrome/installer/util/shell_util.cc:950: base::win::ShortcutProperties
shortcut_properties;
Also add a TODO on base::win::ShortcutProperties's |dual_mode| field to simplify
after Metro removal (that one is a bit more involved I suspect though so I'm
happy to handle it).

[gab, 2016-01-14 17:08:24]

https://codereview.chromium.org/1573243010/diff/20001/chrome/installer/util/s...
File chrome/installer/util/shell_util.cc (left):

https://codereview.chromium.org/1573243010/diff/20001/chrome/installer/util/s...
chrome/installer/util/shell_util.cc:950: base::win::ShortcutProperties
shortcut_properties;
On 2016/01/14 03:22:17, gab wrote:
> Also add a TODO on base::win::ShortcutProperties's |dual_mode| field to
simplify
> after Metro removal (that one is a bit more involved I suspect though so I'm
> happy to handle it).

Actually nvm, looking at what's involved here this morning, it's more than a
code cleanup, we'll need to keep this around for a little while to clean
installed shortcuts first. I'll handle cleanup and dropping TODOs where needed.

[gab, 2016-01-14 17:08:29]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-01-14 17:09:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 17:09:12]

This CL has an open dependency (Issue 1584573004 Patch 20001). Please resolve
the dependency and try again.

[scottmg, 2016-01-14 17:43:23]

Description was changed from

==========
Follow up to https://codereview.chromium.org/1581473002 for Metro removal in
installer

R=gab@chromium.org
BUG=558054
==========

to

==========
Follow up to https://codereview.chromium.org/1581473002 for Metro removal in
installer

Removes ShellUtil::ShortcutProperties' |dual_mode| property.

R=gab@chromium.org
BUG=558054
==========

[scottmg, 2016-01-14 17:46:44]

On 2016/01/14 17:09:12, commit-bot: I haz the power wrote:
> This CL has an open dependency (Issue 1584573004 Patch 20001). Please resolve
> the dependency and try again.

That's a dumb restriction.

I haven't added the registry key value cleanup, I'll post another snap in bit.

Regarding ECHUIM_IMMERSIVE etc, yes, I should have waited a few days, I'm
totally branch-oblivious. :/

[scottmg, 2016-01-14 17:58:30]

On 2016/01/14 17:46:44, scottmg wrote:
> On 2016/01/14 17:09:12, commit-bot: I haz the power wrote:
> > This CL has an open dependency (Issue 1584573004 Patch 20001). Please
resolve
> > the dependency and try again.
> 
> That's a dumb restriction.
> 
> I haven't added the registry key value cleanup, I'll post another snap in bit.

I was going to add it in the delegate_execute code, but I guess that doesn't
make any sense since that'll all go away shortly. So it should probably go
somewhere top-level-er. I filed
https://code.google.com/p/chromium/issues/detail?id=577751 and blocked the main
bug on that.

> 
> Regarding ECHUIM_IMMERSIVE etc, yes, I should have waited a few days, I'm
> totally branch-oblivious. :/

[scottmg, 2016-01-14 18:17:40]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-01-14 18:19:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573243010/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573243010/20001

[commit-bot: I haz the power, 2016-01-14 18:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 18:30:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scottmg, 2016-01-14 18:40:05]

scottmg@chromium.org changed reviewers:
+ thestig@chromium.org

[scottmg, 2016-01-14 18:40:44]

+thestig for chrome/common/chrome_constants.cc (probably should be =* in
chrome/common/OWNERS)

[Lei Zhang, 2016-01-14 19:01:37]

lgtm

[scottmg, 2016-01-14 19:13:49]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-01-14 19:15:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573243010/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573243010/20001

[commit-bot: I haz the power, 2016-01-14 19:24:47]

Description was changed from

==========
Follow up to https://codereview.chromium.org/1581473002 for Metro removal in
installer

Removes ShellUtil::ShortcutProperties' |dual_mode| property.

R=gab@chromium.org
BUG=558054
==========

to

==========
Follow up to https://codereview.chromium.org/1581473002 for Metro removal in
installer

Removes ShellUtil::ShortcutProperties' |dual_mode| property.

R=gab@chromium.org
BUG=558054
==========

[commit-bot: I haz the power, 2016-01-14 19:24:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-14 19:25:51]

Description was changed from

==========
Follow up to https://codereview.chromium.org/1581473002 for Metro removal in
installer

Removes ShellUtil::ShortcutProperties' |dual_mode| property.

R=gab@chromium.org
BUG=558054
==========

to

==========
Follow up to https://codereview.chromium.org/1581473002 for Metro removal in
installer

Removes ShellUtil::ShortcutProperties' |dual_mode| property.

R=gab@chromium.org
BUG=558054

Committed: https://crrev.com/0f4f8338641c6a7a0dc50e0b528f3ade27af0263
Cr-Commit-Position: refs/heads/master@{#369499}
==========

[commit-bot: I haz the power, 2016-01-14 19:25:51]

Patchset 2 (id:??) landed as
https://crrev.com/0f4f8338641c6a7a0dc50e0b528f3ade27af0263
Cr-Commit-Position: refs/heads/master@{#369499}