Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1586843002: Remove remote tree host and some related input and metro_driver code (Closed)

Created:
4 years, 11 months ago by scottmg
Modified:
4 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, tfarina, jam, nona+watch_chromium.org, noyau+watch_chromium.org, shuchen+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remote tree host and some related input and metro_driver code Part of continued stripping out of Metro/Win8/Immersive mode. BUG=558054 Committed: https://crrev.com/5cc04f70e424020d8afe49bdc4c1c76683f0ea7b Cr-Commit-Position: refs/heads/master@{#370068}

Patch Set 1 #

Total comments: 2

Patch Set 2 : gn and remove browser_process_process_part_aurawin #

Patch Set 3 : gn #

Patch Set 4 : rebase #

Patch Set 5 : remove ash_unittests from being run #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8006 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/ash_unittests.isolate View 1 2 3 4 2 chunks +1 line, -15 lines 0 comments Download
D ash/host/ash_remote_window_tree_host_win.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ash/host/ash_remote_window_tree_host_win.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M ash/host/ash_window_tree_host_win.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_process_platform_part.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_platform_part_aurawin.h View 1 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/browser/browser_process_platform_part_aurawin.cc View 1 1 chunk +0 lines, -72 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 2 chunks +0 lines, -9 lines 0 comments Download
D chrome/browser/metro_viewer/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/metro_viewer/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller_chromeos.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller_win.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M printing/printing_context_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 4 6 chunks +0 lines, -21 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/aura/remote_window_tree_host_win.h View 1 chunk +0 lines, -197 lines 0 comments Download
D ui/aura/remote_window_tree_host_win.cc View 1 chunk +0 lines, -522 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ime/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/base/ime/input_method_factory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D ui/base/ime/remote_input_method_delegate_win.h View 1 chunk +0 lines, -42 lines 0 comments Download
D ui/base/ime/remote_input_method_win.h View 1 chunk +0 lines, -100 lines 0 comments Download
D ui/base/ime/remote_input_method_win.cc View 1 chunk +0 lines, -385 lines 0 comments Download
D ui/base/ime/remote_input_method_win_unittest.cc View 1 chunk +0 lines, -831 lines 0 comments Download
M ui/base/ime/ui_base_ime.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/shell_dialogs/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 2 chunks +0 lines, -54 lines 0 comments Download
M ui/shell_dialogs/shell_dialogs.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M win8/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
M win8/delegate_execute/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M win8/delegate_execute/command_execute_impl.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M win8/delegate_execute/delegate_execute.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M win8/metro_driver/BUILD.gn View 1 2 3 chunks +0 lines, -10 lines 0 comments Download
D win8/metro_driver/chrome_app_view_ash.h View 1 chunk +0 lines, -262 lines 0 comments Download
D win8/metro_driver/chrome_app_view_ash.cc View 1 chunk +0 lines, -1464 lines 0 comments Download
D win8/metro_driver/file_picker.h View 1 chunk +0 lines, -18 lines 0 comments Download
D win8/metro_driver/file_picker.cc View 1 chunk +0 lines, -622 lines 0 comments Download
D win8/metro_driver/file_picker_ash.h View 1 chunk +0 lines, -157 lines 0 comments Download
D win8/metro_driver/file_picker_ash.cc View 1 chunk +0 lines, -619 lines 0 comments Download
D win8/metro_driver/metro_driver.h View 1 chunk +0 lines, -17 lines 0 comments Download
D win8/metro_driver/metro_driver.cc View 1 chunk +0 lines, -135 lines 0 comments Download
M win8/metro_driver/metro_driver.gyp View 3 chunks +0 lines, -12 lines 0 comments Download
D win8/metro_driver/metro_driver_win7.cc View 1 chunk +0 lines, -1229 lines 0 comments Download
D win8/viewer/metro_viewer_constants.h View 1 chunk +0 lines, -20 lines 0 comments Download
D win8/viewer/metro_viewer_constants.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D win8/viewer/metro_viewer_exports.h View 1 chunk +0 lines, -29 lines 0 comments Download
D win8/viewer/metro_viewer_process_host.h View 1 chunk +0 lines, -221 lines 0 comments Download
D win8/viewer/metro_viewer_process_host.cc View 1 chunk +0 lines, -346 lines 0 comments Download
M win8/win8.gyp View 1 chunk +0 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (7 generated)
scottmg
ash/, chrome/browser/, ui/aura/, ui/shell_dialogs/: sky@ printing/: thestig@ ui/base/ime/: shuchen@ win8/: ananta@
4 years, 11 months ago (2016-01-13 23:19:17 UTC) #2
Lei Zhang
On 2016/01/13 23:19:17, scottmg wrote: > printing/: thestig@ lgtm
4 years, 11 months ago (2016-01-13 23:35:32 UTC) #4
Shu Chen
ui/base/ime lgtm.
4 years, 11 months ago (2016-01-14 02:41:58 UTC) #5
Shu Chen
Just noticed that this cl will conflict with cl https://codereview.chromium.org/1566083002, which will be merged to ...
4 years, 11 months ago (2016-01-14 07:52:06 UTC) #6
sky
https://codereview.chromium.org/1586843002/diff/1/chrome/browser/browser_process_platform_part_aurawin.cc File chrome/browser/browser_process_platform_part_aurawin.cc (right): https://codereview.chromium.org/1586843002/diff/1/chrome/browser/browser_process_platform_part_aurawin.cc#newcode13 chrome/browser/browser_process_platform_part_aurawin.cc:13: void BrowserProcessPlatformPart::PlatformSpecificCommandLineProcessing( Seems like this class no longer has ...
4 years, 11 months ago (2016-01-14 15:50:09 UTC) #7
scottmg
On 2016/01/14 07:52:06, Shu Chen wrote: > Just noticed that this cl will conflict with ...
4 years, 11 months ago (2016-01-14 18:00:54 UTC) #8
scottmg
https://codereview.chromium.org/1586843002/diff/1/chrome/browser/browser_process_platform_part_aurawin.cc File chrome/browser/browser_process_platform_part_aurawin.cc (right): https://codereview.chromium.org/1586843002/diff/1/chrome/browser/browser_process_platform_part_aurawin.cc#newcode13 chrome/browser/browser_process_platform_part_aurawin.cc:13: void BrowserProcessPlatformPart::PlatformSpecificCommandLineProcessing( On 2016/01/14 15:50:09, sky wrote: > Seems ...
4 years, 11 months ago (2016-01-14 18:20:48 UTC) #9
sky
LGTM
4 years, 11 months ago (2016-01-14 20:39:31 UTC) #10
ananta
metro stuff lgtm
4 years, 11 months ago (2016-01-15 00:06:37 UTC) #11
Shu Chen
On 2016/01/14 18:00:54, scottmg wrote: > On 2016/01/14 07:52:06, Shu Chen wrote: > > Just ...
4 years, 11 months ago (2016-01-15 01:22:54 UTC) #12
scottmg
On 2016/01/15 01:22:54, Shu Chen wrote: > On 2016/01/14 18:00:54, scottmg wrote: > > On ...
4 years, 11 months ago (2016-01-15 03:40:46 UTC) #13
scottmg
+dpranke for testing/ (remove ash_unittests from some lists)
4 years, 11 months ago (2016-01-15 21:23:45 UTC) #15
Dirk Pranke
lgtm
4 years, 11 months ago (2016-01-15 21:35:30 UTC) #16
scottmg
Hi shuchen, do you still need me to hold off on this CL? I think ...
4 years, 11 months ago (2016-01-18 22:57:59 UTC) #17
Shu Chen
On 2016/01/18 22:57:59, scottmg wrote: > Hi shuchen, do you still need me to hold ...
4 years, 11 months ago (2016-01-19 00:22:50 UTC) #18
scottmg
On 2016/01/19 00:22:50, Shu Chen wrote: > On 2016/01/18 22:57:59, scottmg wrote: > > Hi ...
4 years, 11 months ago (2016-01-19 00:28:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586843002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586843002/80001
4 years, 11 months ago (2016-01-19 00:28:28 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-19 01:40:39 UTC) #24
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/5cc04f70e424020d8afe49bdc4c1c76683f0ea7b Cr-Commit-Position: refs/heads/master@{#370068}
4 years, 11 months ago (2016-01-19 01:41:57 UTC) #26
samli
4 years, 11 months ago (2016-01-20 03:05:29 UTC) #27
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1602403002/ by samli@chromium.org.

The reason for reverting is: Suspecting that this is breaking the Webkit Win
(dbg) builder.

First failed build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%....

Powered by Google App Engine
This is Rietveld 408576698