Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1584573004: Remove Metro pinning, and relaunch menu items and strings (Closed)

Created:
4 years, 11 months ago by scottmg
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Metro pinning, and relaunch menu items and strings Also removes the Metro infobar for blocked plugins. NPAPI plugins. Which I don't know why we had at all any more anyway. R=grt, lfg, bauerb, sky TBR=jschuh BUG=558054 Committed: https://crrev.com/363b5904e283b09391552fd398ce73f82387f78e Cr-Commit-Position: refs/heads/master@{#369456}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -311 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/app/chromium_strings.grd View 1 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.h View 1 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 1 chunk +0 lines, -80 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 1 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.cc View 3 chunks +1 line, -75 lines 0 comments Download
M chrome/common/render_messages.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (9 generated)
scottmg
chrome/app: grt@ chrome/browser/guest_view: lfg@ chrome/browser/plugins: bauerb@ chrome/browser/ui, chrome/renderer: sky@
4 years, 11 months ago (2016-01-13 20:28:15 UTC) #3
lfg
chrome/browser/guest_view lgtm
4 years, 11 months ago (2016-01-13 20:40:12 UTC) #4
sky
LGTM
4 years, 11 months ago (2016-01-13 21:19:48 UTC) #5
grt (UTC plus 2)
chrome/app lgtm, but i wonder why remove snap handling from Chrome without also removing it ...
4 years, 11 months ago (2016-01-14 02:21:18 UTC) #6
Bernhard Bauer
LGTM!
4 years, 11 months ago (2016-01-14 10:10:43 UTC) #7
scottmg
On 2016/01/14 02:21:18, grt wrote: > chrome/app lgtm, but i wonder why remove snap handling ...
4 years, 11 months ago (2016-01-14 17:26:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584573004/20001
4 years, 11 months ago (2016-01-14 17:26:50 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/135597)
4 years, 11 months ago (2016-01-14 17:37:37 UTC) #12
scottmg
tbr jschuh for removing a message in render_messages.h
4 years, 11 months ago (2016-01-14 17:48:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584573004/20001
4 years, 11 months ago (2016-01-14 17:50:21 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 17:56:04 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 17:58:03 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/363b5904e283b09391552fd398ce73f82387f78e
Cr-Commit-Position: refs/heads/master@{#369456}

Powered by Google App Engine
This is Rietveld 408576698