chrome/installer/setup/install.cc - Issue 1573243010: Follow up to https://codereview.chromium.org/1581473002 for Metro removal in installer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install.cc

Issue 1573243010: Follow up to https://codereview.chromium.org/1581473002 for Metro removal in installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-2

Patch Set: dual_mode Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install.cc

diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc

index c6da5d15275d0422482d915fab3aba91d85595a5..e905c96fb698286266c9e2fab6f23cb7a9c3ab11 100644

--- a/chrome/installer/setup/install.cc

+++ b/chrome/installer/setup/install.cc

@@ -394,9 +394,6 @@ void CreateOrUpdateShortcuts(

}

ShellUtil::ShortcutProperties start_menu_properties(base_properties);

- // IMPORTANT: Only the default (no arguments and default browserappid) browser

- // shortcut in the Start menu (Start screen on Win8+) should be made dual

- // mode and that prior to Windows 10 only.

if (shortcut_operation == ShellUtil::SHELL_SHORTCUT_CREATE_ALWAYS ||

shortcut_operation ==

ShellUtil::SHELL_SHORTCUT_CREATE_IF_NO_SYSTEM_LEVEL) {

« no previous file with comments | « chrome/installer/mini_installer/chrome.release ('k') | chrome/installer/util/install_util.cc » ('j') | chrome/installer/util/shell_util.cc » ('J')