Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/bubble/bubble_close_reason.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/usb/web_usb_permission_bubble.cc ('k') | components/bubble/bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bubble/bubble_close_reason.h
diff --git a/components/bubble/bubble_close_reason.h b/components/bubble/bubble_close_reason.h
index 68e112d8f88e830256de0b0664330e07943ad987..9c2a2a2faff974880a86e4b2a289c96e862cf4f6 100644
--- a/components/bubble/bubble_close_reason.h
+++ b/components/bubble/bubble_close_reason.h
@@ -36,6 +36,9 @@ enum BubbleCloseReason {
// The user selected a negative response in the bubble.
BUBBLE_CLOSE_CANCELED,
+
+ // A bubble's owning frame is being destroyed.
+ BUBBLE_CLOSE_FRAME_DESTROYED,
};
#endif // COMPONENTS_BUBBLE_BUBBLE_CLOSE_REASON_H_
« no previous file with comments | « chrome/browser/usb/web_usb_permission_bubble.cc ('k') | components/bubble/bubble_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698