chrome/browser/usb/web_usb_permission_bubble.cc - Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/usb/web_usb_permission_bubble.cc

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/usb/web_usb_permission_bubble.cc

diff --git a/chrome/browser/usb/web_usb_permission_bubble.cc b/chrome/browser/usb/web_usb_permission_bubble.cc

index d1f7a8f448efaac8db9987b27959f9f7709de893..6ba7d266ef6fbdb2dbaee68bfb40641487393b64 100644

--- a/chrome/browser/usb/web_usb_permission_bubble.cc

+++ b/chrome/browser/usb/web_usb_permission_bubble.cc

@@ -34,7 +34,8 @@ void ChromeWebUsbPermissionBubble::GetPermission(

content::WebContents::FromRenderFrameHost(render_frame_host_);

Browser* browser = chrome::FindBrowserWithWebContents(web_contents);

scoped_ptr<UsbChooserBubbleDelegate> bubble_delegate(

- new UsbChooserBubbleDelegate(browser, std::move(device_filters),

+ new UsbChooserBubbleDelegate(render_frame_host_,

+ std::move(device_filters),

render_frame_host_, callback));

UsbChooserBubbleDelegate* bubble_delegate_ptr = bubble_delegate.get();

BubbleReference bubble_controller =

« no previous file with comments | « chrome/browser/usb/usb_chooser_bubble_delegate.cc ('k') | components/bubble/bubble_close_reason.h » ('j') | no next file with comments »