components/bubble/bubble_close_reason.h - Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/bubble/bubble_close_reason.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/usb/web_usb_permission_bubble.cc ('k') | components/bubble/bubble_controller.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_BUBBLE_BUBBLE_CLOSE_REASON_H_	5 #ifndef COMPONENTS_BUBBLE_BUBBLE_CLOSE_REASON_H_

6 #define COMPONENTS_BUBBLE_BUBBLE_CLOSE_REASON_H_	6 #define COMPONENTS_BUBBLE_BUBBLE_CLOSE_REASON_H_

7	7

8 // List of reasons why a bubble might close. These correspond to various events	8 // List of reasons why a bubble might close. These correspond to various events

9 // from the UI. Not all platforms will receive all events.	9 // from the UI. Not all platforms will receive all events.

10 enum BubbleCloseReason {	10 enum BubbleCloseReason {

(...skipping 18 matching lines...) Expand all Loading...
29	29

30 // The parent window has entered or exited fullscreen mode. Will also be	30 // The parent window has entered or exited fullscreen mode. Will also be

31 // called for immersive fullscreen.	31 // called for immersive fullscreen.

32 BUBBLE_CLOSE_FULLSCREEN_TOGGLED,	32 BUBBLE_CLOSE_FULLSCREEN_TOGGLED,

33	33

34 // The user selected an affirmative response in the bubble.	34 // The user selected an affirmative response in the bubble.

35 BUBBLE_CLOSE_ACCEPTED,	35 BUBBLE_CLOSE_ACCEPTED,

36	36

37 // The user selected a negative response in the bubble.	37 // The user selected a negative response in the bubble.

38 BUBBLE_CLOSE_CANCELED,	38 BUBBLE_CLOSE_CANCELED,

	39

	40 // A bubble's owning frame is being destroyed.

	41 BUBBLE_CLOSE_FRAME_DESTROYED,

39 };	42 };

40	43

41 #endif // COMPONENTS_BUBBLE_BUBBLE_CLOSE_REASON_H_	44 #endif // COMPONENTS_BUBBLE_BUBBLE_CLOSE_REASON_H_

OLD	NEW