Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: components/bubble/bubble_controller.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bubble/bubble_close_reason.h ('k') | components/bubble/bubble_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bubble/bubble_controller.h
diff --git a/components/bubble/bubble_controller.h b/components/bubble/bubble_controller.h
index f86452f762c9a95ee541bee1fb32a8f913ebd3b0..78889be30a242b2f59ffcc45662b8c9429986be2 100644
--- a/components/bubble/bubble_controller.h
+++ b/components/bubble/bubble_controller.h
@@ -15,6 +15,10 @@ class BubbleDelegate;
class BubbleManager;
class BubbleUi;
+namespace content {
+class RenderFrameHost;
+}
+
// BubbleController is responsible for the lifetime of the delegate and its UI.
class BubbleController : public base::SupportsWeakPtr<BubbleController> {
public:
@@ -48,6 +52,9 @@ class BubbleController : public base::SupportsWeakPtr<BubbleController> {
// Returns true if the bubble should be closed.
bool ShouldClose(BubbleCloseReason reason) const;
+ // Returns true if |frame| owns this bubble.
+ bool OwningFrameIs(const content::RenderFrameHost* frame) const;
+
// Cleans up the delegate and its UI.
void DoClose();
« no previous file with comments | « components/bubble/bubble_close_reason.h ('k') | components/bubble/bubble_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698