[Binding] Support primitive type for union member

[Binding] Support primitive type for union member

Support primitive type such as unsigned long for union member.
Now we can write in IDL:
getter (Node or unsigned long) (DOMString name);

Auto-generate V8NodeList::namedPropertyGetter with the feature.
Introduce [NoNamedGetter] which means the IDL do not expose
named getter even if parent IDL have one.

Rename [DoNotCheckJSProperty] with [OverrideBuiltins]
per spec:
http://www.w3.org/TR/WebIDL/#OverrideBuiltins

R=haraken@chromium.org
BUG=229740
TEST=TestInterface.idl

[kojih, 2013-05-23 04:05:54]

r?

[kojih, 2013-05-23 05:14:26]

Diff of generated code:

diff -u /mnt/hdd/diff/gen_master/V8HTMLAllCollection.cpp
/mnt/hdd/diff/gen_nodel/V8HTMLAllCollection.cpp
--- /mnt/hdd/diff/gen_master/V8HTMLAllCollection.cpp    2013-05-23
11:44:29.862141597 +0900
+++ /mnt/hdd/diff/gen_nodel/V8HTMLAllCollection.cpp     2013-05-23
13:15:16.404211724 +0900
@@ -143,12 +143,14 @@
     ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
     HTMLAllCollection* collection = toNative(info.Holder());
     AtomicString propertyName = toWebCoreAtomicString(name);
+    bool element0Enabled = false;
     RefPtr<NodeList> element0;
+    bool element1Enabled = false;
     RefPtr<Node> element1;
-    collection->anonymousNamedGetter(propertyName, element0, element1);
-    if (!!element0)
+    collection->anonymousNamedGetter(propertyName, element0Enabled, element0,
element1Enabled, element1);
+    if (element0Enabled && !!element0)
         return toV8Fast(element0.release(), info, collection);
-    if (!!element1)
+    if (element1Enabled && !!element1)
         return toV8Fast(element1.release(), info, collection);
     return v8Undefined();
 }
diff -u /mnt/hdd/diff/gen_master/V8HTMLFormControlsCollection.cpp
/mnt/hdd/diff/gen_nodel/V8HTMLFormControlsCollection.cp
p
--- /mnt/hdd/diff/gen_master/V8HTMLFormControlsCollection.cpp   2013-05-23
11:44:29.862141597 +0900
+++ /mnt/hdd/diff/gen_nodel/V8HTMLFormControlsCollection.cpp    2013-05-23
13:15:16.404211724 +0900
@@ -106,12 +106,14 @@
     ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
     HTMLFormControlsCollection* collection = toNative(info.Holder());
     AtomicString propertyName = toWebCoreAtomicString(name);
+    bool element0Enabled = false;
     RefPtr<RadioNodeList> element0;
+    bool element1Enabled = false;
     RefPtr<Node> element1;
-    collection->namedGetter(propertyName, element0, element1);
-    if (!!element0)
+    collection->namedGetter(propertyName, element0Enabled, element0,
element1Enabled, element1);
+    if (element0Enabled && !!element0)
         return toV8Fast(element0.release(), info, collection);
-    if (!!element1)
+    if (element1Enabled && !!element1)
         return toV8Fast(element1.release(), info, collection);
     return v8Undefined();
 }
diff -u /mnt/hdd/diff/gen_master/V8HTMLFormElement.cpp
/mnt/hdd/diff/gen_nodel/V8HTMLFormElement.cpp
--- /mnt/hdd/diff/gen_master/V8HTMLFormElement.cpp      2013-05-23
11:44:29.862141597 +0900
+++ /mnt/hdd/diff/gen_nodel/V8HTMLFormElement.cpp       2013-05-23
13:15:16.404211724 +0900
@@ -444,12 +444,14 @@
     ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
     HTMLFormElement* collection = toNative(info.Holder());
     AtomicString propertyName = toWebCoreAtomicString(name);
+    bool element0Enabled = false;
     RefPtr<NodeList> element0;
+    bool element1Enabled = false;
     RefPtr<Node> element1;
-    collection->anonymousNamedGetter(propertyName, element0, element1);
-    if (!!element0)
+    collection->anonymousNamedGetter(propertyName, element0Enabled, element0,
element1Enabled, element1);
+    if (element0Enabled && !!element0)
         return toV8Fast(element0.release(), info, collection);
-    if (!!element1)
+    if (element1Enabled && !!element1)
         return toV8Fast(element1.release(), info, collection);
     return v8Undefined();
 }
diff -u /mnt/hdd/diff/gen_master/V8HTMLOptionsCollection.cpp
/mnt/hdd/diff/gen_nodel/V8HTMLOptionsCollection.cpp
--- /mnt/hdd/diff/gen_master/V8HTMLOptionsCollection.cpp        2013-05-23
11:44:29.862141597 +0900
+++ /mnt/hdd/diff/gen_nodel/V8HTMLOptionsCollection.cpp 2013-05-23
13:15:16.404211724 +0900
@@ -165,12 +165,14 @@
     ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
     HTMLOptionsCollection* collection = toNative(info.Holder());
     AtomicString propertyName = toWebCoreAtomicString(name);
+    bool element0Enabled = false;
     RefPtr<NodeList> element0;
+    bool element1Enabled = false;
     RefPtr<Node> element1;
-    collection->anonymousNamedGetter(propertyName, element0, element1);
-    if (!!element0)
+    collection->anonymousNamedGetter(propertyName, element0Enabled, element0,
element1Enabled, element1);
+    if (element0Enabled && !!element0)
         return toV8Fast(element0.release(), info, collection);
-    if (!!element1)
+    if (element1Enabled && !!element1)
         return toV8Fast(element1.release(), info, collection);
     return v8Undefined();
 }
diff -u /mnt/hdd/diff/gen_master/V8NodeList.cpp
/mnt/hdd/diff/gen_nodel/V8NodeList.cpp
--- /mnt/hdd/diff/gen_master/V8NodeList.cpp     2013-05-23 11:44:29.862141597
+0900
+++ /mnt/hdd/diff/gen_nodel/V8NodeList.cpp      2013-05-23 13:15:16.414211802
+0900
@@ -107,6 +107,24 @@
     return toV8Fast(element.release(), info, collection);
 }
 
+v8::Handle<v8::Value> V8NodeList::namedPropertyGetter(v8::Local<v8::String>
name, const v8::AccessorInfo& info)
+{
+
+    ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
+    NodeList* collection = toNative(info.Holder());
+    AtomicString propertyName = toWebCoreAtomicString(name);
+    bool element0Enabled = false;
+    RefPtr<Node> element0;
+    bool element1Enabled = false;
+    unsigned element1;
+    collection->anonymousNamedGetter(propertyName, element0Enabled, element0,
element1Enabled, element1);
+    if (element0Enabled && !!element0)
+        return toV8Fast(element0.release(), info, collection);
+    if (element1Enabled)
+        return v8UnsignedInteger(element1, info.GetIsolate());
+    return v8Undefined();
+}
+

https://codereview.chromium.org/15724005/diff/3001/Source/bindings/scripts/Co...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/15724005/diff/3001/Source/bindings/scripts/Co...
Source/bindings/scripts/CodeGeneratorV8.pm:566: 
quit searching all parents for special method

https://codereview.chromium.org/15724005/diff/3001/Source/bindings/scripts/Co...
Source/bindings/scripts/CodeGeneratorV8.pm:3037: return "";
primitive case

https://codereview.chromium.org/15724005/diff/3001/Source/core/dom/NodeList.cpp
File Source/core/dom/NodeList.cpp (right):

https://codereview.chromium.org/15724005/diff/3001/Source/core/dom/NodeList.c...
Source/core/dom/NodeList.cpp:42: if (name == length) {
I tried to add [OverrideBuiltins] and remove this check,
but fast/js/getOwnPropertyDescriptor.html tesst failed.

FAIL Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'),
'length').enumerable should be true. Was false.

I will fix it in following patch.

[haraken, 2013-05-23 05:56:27]

The patch looks good overall, but you are doing too many things in one CL.
Please upload them one by one in order to avoid regressions.

- Rename [DoNotCheckJSProperty] to [OverrideBuiltins]
- Add xxxEnabled parameters
- Add more named getters
- Remove custom named getters of NodeList
- etc

https://codereview.chromium.org/15724005/diff/3001/Source/bindings/tests/resu...
File Source/bindings/tests/results/V8TestInterface.cpp (right):

https://codereview.chromium.org/15724005/diff/3001/Source/bindings/tests/resu...
Source/bindings/tests/results/V8TestInterface.cpp:538: if (element0Enabled &&
!!element0)

Just to confirm: You added '&& !!element0' just in case, right? I'm OK with
adding it just in case.

https://codereview.chromium.org/15724005/diff/3001/Source/core/core.gypi
File Source/core/core.gypi (right):

https://codereview.chromium.org/15724005/diff/3001/Source/core/core.gypi#newc...
Source/core/core.gypi:1810: 'dom/NodeList.cpp',

Nit: alphabetical order please.

https://codereview.chromium.org/15724005/diff/3001/Source/core/dom/NodeList.cpp
File Source/core/dom/NodeList.cpp (right):

https://codereview.chromium.org/15724005/diff/3001/Source/core/dom/NodeList.c...
Source/core/dom/NodeList.cpp:42: if (name == length) {

OK, let's keep the current code as is and investigate the issue later.

https://codereview.chromium.org/15724005/diff/3001/Source/core/html/DOMSettab...
File Source/core/html/DOMSettableTokenList.idl (right):

https://codereview.chromium.org/15724005/diff/3001/Source/core/html/DOMSettab...
Source/core/html/DOMSettableTokenList.idl:27: [TreatReturnedNullStringAs=Null,
ImplementedAs=item] getter DOMString(unsigned long index);

Why do we need to add [TreatReturnedNullStringAs=Null]?