Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: Source/core/dom/NodeList.cpp

Issue 15724005: [Binding] Support primitive type for union member (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: do not inherit getter. rename DoNotCheckJSProperty to OverrideBuiltins Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/NodeList.cpp
diff --git a/Source/core/html/ime/Composition.cpp b/Source/core/dom/NodeList.cpp
similarity index 73%
copy from Source/core/html/ime/Composition.cpp
copy to Source/core/dom/NodeList.cpp
index 49b0bf119ebebe9c2904d5fd22f22b064b84ee90..2c386daf14ed1f51437e8bf3151317905b98fa63 100644
--- a/Source/core/html/ime/Composition.cpp
+++ b/Source/core/dom/NodeList.cpp
@@ -1,10 +1,10 @@
/*
* Copyright (C) 2013 Google Inc. All rights reserved.
- *
+ *
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
* met:
- *
+ *
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above
@@ -14,7 +14,7 @@
* * Neither the name of Google Inc. nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
- *
+ *
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
@@ -29,26 +29,29 @@
*/
#include "config.h"
-#include "core/html/ime/Composition.h"
+#include "core/dom/NodeList.h"
#include "core/dom/Node.h"
-#include "core/dom/Range.h"
namespace WebCore {
-Composition::~Composition()
+void NodeList::anonymousNamedGetter(const AtomicString& name, bool& returnValue0Enabled, RefPtr<Node>& returnValue0, bool& returnValue1Enabled, unsigned& returnValue1)
{
-}
+ // Length property cannot be overridden.
+ DEFINE_STATIC_LOCAL(const AtomicString, length, ("length", AtomicString::ConstructFromLiteral));
+ if (name == length) {
kojih 2013/05/23 05:14:26 I tried to add [OverrideBuiltins] and remove this
haraken 2013/05/23 05:56:27 OK, let's keep the current code as is and investig
+ returnValue1Enabled = true;
+ returnValue1 = this->length();
+ return;
+ }
-PassRefPtr<Composition> Composition::create(Node* text, Range* caret)
-{
- return adoptRef(new Composition(text, caret));
-}
+ Node* result = namedItem(name);
+ if (!result)
+ return;
-Composition::Composition(Node* text, Range* caret)
- : m_text(text)
- , m_caret(caret)
-{
+ returnValue0Enabled = true;
+ returnValue0 = result;
}
+
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698