Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: Source/bindings/v8/custom/V8NodeListCustom.cpp

Issue 15724005: [Binding] Support primitive type for union member (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: do not inherit getter. rename DoNotCheckJSProperty to OverrideBuiltins Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8NodeListCustom.cpp
diff --git a/Source/bindings/v8/custom/V8NodeListCustom.cpp b/Source/bindings/v8/custom/V8NodeListCustom.cpp
index 42139e08ade379ed9d9650ab70a741c7ca9d3521..23edd385f990904a7360c1b7371a8cd9c278dad6 100644
--- a/Source/bindings/v8/custom/V8NodeListCustom.cpp
+++ b/Source/bindings/v8/custom/V8NodeListCustom.cpp
@@ -42,23 +42,6 @@
namespace WebCore {
-v8::Handle<v8::Value> V8NodeList::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
-{
- NodeList* list = V8NodeList::toNative(info.Holder());
- AtomicString key = toWebCoreAtomicString(name);
-
- // Length property cannot be overridden.
- DEFINE_STATIC_LOCAL(const AtomicString, length, ("length", AtomicString::ConstructFromLiteral));
- if (key == length)
- return v8Integer(list->length(), info.GetIsolate());
-
- RefPtr<Node> result = list->namedItem(key);
- if (!result)
- return v8Undefined();
-
- return toV8Fast(result.release(), info, list);
-}
-
void* V8NodeList::opaqueRootForGC(void* object, v8::Persistent<v8::Object> wrapper, v8::Isolate* isolate)
{
ASSERT(V8NodeList::HasInstanceInAnyWorld(wrapper, isolate));

Powered by Google App Engine
This is Rietveld 408576698