Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1570503002: Revert of Broke GrTessellatingPathRenderer's tessellator out into a separate file. (Closed)

Created:
4 years, 11 months ago by caryclark
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Broke GrTessellatingPathRenderer's tessellator out into a separate file. (patchset #8 id:240001 of https://codereview.chromium.org/1557083002/ ) Reason for revert: broke valgrind bot Original issue's description: > Broke GrTessellatingPathRenderer's tessellator out into a separate file. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1557083002 > > Committed: https://skia.googlesource.com/skia/+/8b05cb8a00bdb82e100f1ba74bf4de4a504cceea TBR=bsalomon@google.com,joshualitt@chromium.org,senorblanco@chromium.org,ethannicholas@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/fb8243717300309853ff3d881b68feddd9c7b5c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1406 lines, -1539 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D src/gpu/GrTessellator.h View 1 chunk +0 lines, -40 lines 0 comments Download
D src/gpu/GrTessellator.cpp View 1 chunk +0 lines, -1469 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 5 chunks +1406 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
caryclark
Created Revert of Broke GrTessellatingPathRenderer's tessellator out into a separate file.
4 years, 11 months ago (2016-01-07 13:09:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570503002/1
4 years, 11 months ago (2016-01-07 13:09:43 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 13:09:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fb8243717300309853ff3d881b68feddd9c7b5c9

Powered by Google App Engine
This is Rietveld 408576698