Adds --skip-clear-data flag to android's test_runner.py

Adds --skip-clear-data flag to android's test_runner.py

Meant to be used to speed up local development. Mostly applicable when running instrumentation tests against _incremental .apks.

BUG=540857
Committed: https://crrev.com/cd243a271a150e4e68c988e0bf96865f6ff79a06
Cr-Commit-Position: refs/heads/master@{#374211}

[agrieve, 2016-01-08 21:22:42]

Description was changed from

==========
Adds --skip-clear-data flag to android's test_runner.py

Meant to be used to speed up local development

BUG=540857
==========

to

==========
Adds --skip-clear-data flag to android's test_runner.py

Meant to be used to speed up local development

BUG=540857
==========

[agrieve, 2016-01-08 21:22:42]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-01-08 21:23:05]

On 2016/01/08 21:22:42, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

۩۞۩

[agrieve, 2016-01-08 21:34:25]

Description was changed from

==========
Adds --skip-clear-data flag to android's test_runner.py

Meant to be used to speed up local development

BUG=540857
==========

to

==========
Adds --skip-clear-data flag to android's test_runner.py

Meant to be used to speed up local development. Mostly applicable when running
instrumentation tests against _incremental .apks.

BUG=540857
==========

[agrieve, 2016-02-03 03:18:55]

On 2016/01/08 21:23:05, agrieve wrote:
> On 2016/01/08 21:22:42, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:jbudorick@chromium.org
> 
> ۩۞۩

bump

[jbudorick, 2016-02-03 14:38:27]

I'm wondering if all of the developer-aimed flag-controlled behavior could be
grouped behind a single flag.

Also, please add this to the TODO here:
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli...

https://codereview.chromium.org/1570043004/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_gtest_run.py (right):

https://codereview.chromium.org/1570043004/diff/20001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_gtest_run.py:347: if not
self._test_instance.skip_clear_data:
Why are we adding this in addition to --incremental-install?

[agrieve, 2016-02-03 16:34:32]

Update the TODO.

https://codereview.chromium.org/1570043004/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_gtest_run.py (right):

https://codereview.chromium.org/1570043004/diff/20001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_gtest_run.py:347: if not
self._test_instance.skip_clear_data:
On 2016/02/03 14:38:27, jbudorick wrote:
> Why are we adding this in addition to --incremental-install?

I'm envisioning adding a --fast-local-dev (or better name appreciated), which
will turn on all of these iffy flags, and which will be used by the _incremental
generated script, but also useful for non-incremental local builds.

[agrieve, 2016-02-08 15:12:23]

On 2016/02/03 16:34:32, agrieve wrote:
> Update the TODO.
> 
>
https://codereview.chromium.org/1570043004/diff/20001/build/android/pylib/loc...
> File build/android/pylib/local/device/local_device_gtest_run.py (right):
> 
>
https://codereview.chromium.org/1570043004/diff/20001/build/android/pylib/loc...
> build/android/pylib/local/device/local_device_gtest_run.py:347: if not
> self._test_instance.skip_clear_data:
> On 2016/02/03 14:38:27, jbudorick wrote:
> > Why are we adding this in addition to --incremental-install?
> 
> I'm envisioning adding a --fast-local-dev (or better name appreciated), which
> will turn on all of these iffy flags, and which will be used by the
_incremental
> generated script, but also useful for non-incremental local builds.

nudge

[jbudorick, 2016-02-08 16:08:01]

On 2016/02/08 15:12:23, agrieve wrote:
> On 2016/02/03 16:34:32, agrieve wrote:
> > Update the TODO.
> > 
> >
>
https://codereview.chromium.org/1570043004/diff/20001/build/android/pylib/loc...
> > File build/android/pylib/local/device/local_device_gtest_run.py (right):
> > 
> >
>
https://codereview.chromium.org/1570043004/diff/20001/build/android/pylib/loc...
> > build/android/pylib/local/device/local_device_gtest_run.py:347: if not
> > self._test_instance.skip_clear_data:
> > On 2016/02/03 14:38:27, jbudorick wrote:
> > > Why are we adding this in addition to --incremental-install?
> > 
> > I'm envisioning adding a --fast-local-dev (or better name appreciated),
which
> > will turn on all of these iffy flags, and which will be used by the
> _incremental
> > generated script, but also useful for non-incremental local builds.
> 
> nudge

so many CLs

(reviewing)

[jbudorick, 2016-02-08 16:09:02]

lgtm

[agrieve, 2016-02-08 16:43:07]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-02-08 16:43:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570043004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570043004/40001

[commit-bot: I haz the power, 2016-02-08 19:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 19:41:58]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-02-08 21:25:26]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-02-08 21:35:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570043004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570043004/40001

[commit-bot: I haz the power, 2016-02-08 23:25:24]

Description was changed from

==========
Adds --skip-clear-data flag to android's test_runner.py

Meant to be used to speed up local development. Mostly applicable when running
instrumentation tests against _incremental .apks.

BUG=540857
==========

to

==========
Adds --skip-clear-data flag to android's test_runner.py

Meant to be used to speed up local development. Mostly applicable when running
instrumentation tests against _incremental .apks.

BUG=540857
==========

[commit-bot: I haz the power, 2016-02-08 23:25:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-08 23:27:16]

Description was changed from

==========
Adds --skip-clear-data flag to android's test_runner.py

Meant to be used to speed up local development. Mostly applicable when running
instrumentation tests against _incremental .apks.

BUG=540857
==========

to

==========
Adds --skip-clear-data flag to android's test_runner.py

Meant to be used to speed up local development. Mostly applicable when running
instrumentation tests against _incremental .apks.

BUG=540857

Committed: https://crrev.com/cd243a271a150e4e68c988e0bf96865f6ff79a06
Cr-Commit-Position: refs/heads/master@{#374211}
==========

[commit-bot: I haz the power, 2016-02-08 23:27:17]

Patchset 3 (id:??) landed as
https://crrev.com/cd243a271a150e4e68c988e0bf96865f6ff79a06
Cr-Commit-Position: refs/heads/master@{#374211}