Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1661253002:
test_runner.py Add --fast-local-dev flag (Closed)
|
Created:
4 years, 10 months ago by agrieve Modified:
4 years, 10 months ago Reviewers:
jbudorick CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@tests-no-clear-data Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiontest_runner.py Add --fast-local-dev flag
As a shorthand for: --verbose --num-retries=0 --enable-device-cache \
--skip-clear-data --extract-test-list-from-filter
BUG=None
Committed: https://crrev.com/7acf04affd5578d00f3f437704dc0120db5bc773
Cr-Commit-Position: refs/heads/master@{#374420}
Patch Set 1 #
Total comments: 2
Patch Set 2 : rebase #
Depends on Patchset: Messages
Total messages: 21 (10 generated)
Description was changed from
==========
test_runner.py Add --fast-local-dev flag
As a shorthand for: --verbose --num-retries=0 --enable-device-cache \
--skip-clear-data --extract-test-list-from-filter
BUG=None
==========
to
==========
test_runner.py Add --fast-local-dev flag
As a shorthand for: --verbose --num-retries=0 --enable-device-cache \
--skip-clear-data --extract-test-list-from-filter
BUG=None
==========
agrieve@chromium.org changed reviewers: + jbudorick@chromium.org
On 2016/02/04 03:08:52, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org ❃
lgtm ? https://codereview.chromium.org/1661253002/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/1661253002/diff/1/build/android/test_runner.p... build/android/test_runner.py:116: class FastLocalDevAction(argparse.Action): I would normally be against a local class, but this is so specific that ... maybe? I also have no idea what the appropriate naming style is for it. We've done lower_case_with_underscores for local functions to distinguish them as local functions, but I feel like that'd be weird here, so I guess this is ok.
https://codereview.chromium.org/1661253002/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/1661253002/diff/1/build/android/test_runner.p... build/android/test_runner.py:116: class FastLocalDevAction(argparse.Action): On 2016/02/04 05:34:24, jbudorick wrote: > I would normally be against a local class, but this is so specific that ... > maybe? > > I also have no idea what the appropriate naming style is for it. We've done > lower_case_with_underscores for local functions to distinguish them as local > functions, but I feel like that'd be weird here, so I guess this is ok. Yeah, there's another one already on line 607, so at least it's consistent there.
On 2016/02/04 16:09:14, agrieve wrote: > https://codereview.chromium.org/1661253002/diff/1/build/android/test_runner.py > File build/android/test_runner.py (right): > > https://codereview.chromium.org/1661253002/diff/1/build/android/test_runner.p... > build/android/test_runner.py:116: class FastLocalDevAction(argparse.Action): > On 2016/02/04 05:34:24, jbudorick wrote: > > I would normally be against a local class, but this is so specific that ... > > maybe? > > > > I also have no idea what the appropriate naming style is for it. We've done > > lower_case_with_underscores for local functions to distinguish them as local > > functions, but I feel like that'd be weird here, so I guess this is ok. > > Yeah, there's another one already on line 607, so at least it's consistent > there. ah, fair. sgtm.
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661253002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661253002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by agrieve@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/1661253002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661253002/20001
Message was sent while issue was closed.
Description was changed from
==========
test_runner.py Add --fast-local-dev flag
As a shorthand for: --verbose --num-retries=0 --enable-device-cache \
--skip-clear-data --extract-test-list-from-filter
BUG=None
==========
to
==========
test_runner.py Add --fast-local-dev flag
As a shorthand for: --verbose --num-retries=0 --enable-device-cache \
--skip-clear-data --extract-test-list-from-filter
BUG=None
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from
==========
test_runner.py Add --fast-local-dev flag
As a shorthand for: --verbose --num-retries=0 --enable-device-cache \
--skip-clear-data --extract-test-list-from-filter
BUG=None
==========
to
==========
test_runner.py Add --fast-local-dev flag
As a shorthand for: --verbose --num-retries=0 --enable-device-cache \
--skip-clear-data --extract-test-list-from-filter
BUG=None
Committed: https://crrev.com/7acf04affd5578d00f3f437704dc0120db5bc773
Cr-Commit-Position: refs/heads/master@{#374420}
==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7acf04affd5578d00f3f437704dc0120db5bc773 Cr-Commit-Position: refs/heads/master@{#374420} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
