Android gtest runner: Only query device for test list when necessary (take 2)

Android gtest runner: Only query device for test list when necessary (take 2)

This broke bots due to http://crbug.com/549214

Adding back but behind a flag (--extract-test-list-from-filter).
Enabling-by-default for incremental-install gtests.

Original review: https://codereview.chromium.org/1393223002

BUG=540857, 549214
Committed: https://crrev.com/0f5e53ea3c88b0432588510d3b416fb5dd6cb58a
Cr-Commit-Position: refs/heads/master@{#373450}

[agrieve, 2016-01-08 19:16:42]

Description was changed from

==========
Android gtest runner: Only query device for test list when necessary (take 2)

This broke bots due to http://crbug.com/549214

Adding back but behind a flag. Enabling-by-default for
incremental-install gtests.

BUG=540857,549214

Android gtest runner: Only query device for test list when necessary

When --gtest_filter is used and contains a list of tests without
wildcards, it is not necessary to query the device for the list of
tests.

This speeds up local development where it's comment to run just a single
test at a time (saves 3 seconds).

BUG=540857
==========

to

==========
Android gtest runner: Only query device for test list when necessary (take 2)

This broke bots due to http://crbug.com/549214

Adding back but behind a flag. Enabling-by-default for
incremental-install gtests.

Original review: https://codereview.chromium.org/1393223002

BUG=540857,549214
==========

[agrieve, 2016-01-08 19:16:42]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-01-08 19:18:36]

On 2016/01/08 19:16:42, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

•ิ•ิ•ิ•ิ

[agrieve, 2016-01-19 15:51:56]

Description was changed from

==========
Android gtest runner: Only query device for test list when necessary (take 2)

This broke bots due to http://crbug.com/549214

Adding back but behind a flag. Enabling-by-default for
incremental-install gtests.

Original review: https://codereview.chromium.org/1393223002

BUG=540857,549214
==========

to

==========
Android gtest runner: Only query device for test list when necessary (take 2)

This broke bots due to http://crbug.com/549214

Adding back but behind a flag (--extract-test-list-from-filter).
Enabling-by-default for incremental-install gtests.

Original review: https://codereview.chromium.org/1393223002

BUG=540857,549214
==========

[agrieve, 2016-02-02 18:55:56]

On 2016/01/08 19:18:36, agrieve wrote:
> On 2016/01/08 19:16:42, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:jbudorick@chromium.org
> 
> •ิ•ิ•ิ•ิ

bump

[jbudorick, 2016-02-03 14:25:18]

lgtm w/ nit

https://codereview.chromium.org/1576473002/diff/20001/build/android/test_runn...
File build/android/test_runner.py (right):

https://codereview.chromium.org/1576473002/diff/20001/build/android/test_runn...
build/android/test_runner.py:260: 'tests can be determined from it, skip
querying the '
nit: indent to opening '

[agrieve, 2016-02-03 16:02:02]

https://codereview.chromium.org/1576473002/diff/20001/build/android/test_runn...
File build/android/test_runner.py (right):

https://codereview.chromium.org/1576473002/diff/20001/build/android/test_runn...
build/android/test_runner.py:260: 'tests can be determined from it, skip
querying the '
On 2016/02/03 14:25:17, jbudorick wrote:
> nit: indent to opening '

Done.

[agrieve, 2016-02-03 16:02:10]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-02-03 16:02:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1576473002/#ps40001
(title: "indentation fix")

[commit-bot: I haz the power, 2016-02-03 16:02:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576473002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576473002/40001

[commit-bot: I haz the power, 2016-02-03 16:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 16:05:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[agrieve, 2016-02-04 02:17:56]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-02-04 02:18:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576473002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576473002/40001

[commit-bot: I haz the power, 2016-02-04 03:47:43]

Description was changed from

==========
Android gtest runner: Only query device for test list when necessary (take 2)

This broke bots due to http://crbug.com/549214

Adding back but behind a flag (--extract-test-list-from-filter).
Enabling-by-default for incremental-install gtests.

Original review: https://codereview.chromium.org/1393223002

BUG=540857,549214
==========

to

==========
Android gtest runner: Only query device for test list when necessary (take 2)

This broke bots due to http://crbug.com/549214

Adding back but behind a flag (--extract-test-list-from-filter).
Enabling-by-default for incremental-install gtests.

Original review: https://codereview.chromium.org/1393223002

BUG=540857,549214
==========

[commit-bot: I haz the power, 2016-02-04 03:47:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-04 03:48:51]

Description was changed from

==========
Android gtest runner: Only query device for test list when necessary (take 2)

This broke bots due to http://crbug.com/549214

Adding back but behind a flag (--extract-test-list-from-filter).
Enabling-by-default for incremental-install gtests.

Original review: https://codereview.chromium.org/1393223002

BUG=540857,549214
==========

to

==========
Android gtest runner: Only query device for test list when necessary (take 2)

This broke bots due to http://crbug.com/549214

Adding back but behind a flag (--extract-test-list-from-filter).
Enabling-by-default for incremental-install gtests.

Original review: https://codereview.chromium.org/1393223002

BUG=540857,549214

Committed: https://crrev.com/0f5e53ea3c88b0432588510d3b416fb5dd6cb58a
Cr-Commit-Position: refs/heads/master@{#373450}
==========

[commit-bot: I haz the power, 2016-02-04 03:48:52]

Patchset 3 (id:??) landed as
https://crrev.com/0f5e53ea3c88b0432588510d3b416fb5dd6cb58a
Cr-Commit-Position: refs/heads/master@{#373450}