build/android/pylib/local/device/local_device_gtest_run.py - Issue 1570043004: Adds --skip-clear-data flag to android's test_runner.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 1570043004: Adds --skip-clear-data flag to android's test_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update todo Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/instrumentation/test_runner.py ('k') | build/android/pylib/local/device/local_device_instrumentation_test_run.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/local/device/local_device_gtest_run.py

diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py

index 740a8c37364e935de9f03dbb250bfafd717f343f..42178907cf9361762f499615fb00b93dfccb7ddf 100644

--- a/build/android/pylib/local/device/local_device_gtest_run.py

+++ b/build/android/pylib/local/device/local_device_gtest_run.py

@@ -345,9 +345,7 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):

if self._test_instance.app_files:

self._delegate.PullAppFiles(device, self._test_instance.app_files,

self._test_instance.app_file_dir)

- # Clearing data when using incremental install wipes out cached optimized

- # dex files (and shouldn't be necessary by tests anyways).

- if not self._env.incremental_install:

+ if not self._test_instance.skip_clear_data:

self._delegate.Clear(device)

# Parse the output.