Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1568433005: Platform WebUnitTestSupport onion soup: remove more indirect methods (Closed)

Created:
4 years, 11 months ago by kinuko
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, darin-cc_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, esprehn, f(malita), jam, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Platform WebUnitTestSupport onion soup: remove more indirect methods Removing following three indirect methods which can be directly implemented within blink platform: - readFromFile - enterRunLoop - exitRunLoop BUG=571332 TBR=danakj Committed: https://crrev.com/bc2335ab3bfc8f9bcbacf4a1264ece280b73c288 Cr-Commit-Position: refs/heads/master@{#368473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -40 lines) Patch
M content/test/test_blink_web_unit_test_support.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/TestFontSelector.h View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp View 3 chunks +25 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/MHTMLTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebImageTest.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebUnitTestSupport.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
kinuko
Another relatively innocent/easy changes for onion soup- could you take a look?
4 years, 11 months ago (2016-01-07 01:28:06 UTC) #6
kinuko
Jochen, could you review platform changes? They should look very straightforward.
4 years, 11 months ago (2016-01-08 11:39:52 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-08 14:06:44 UTC) #9
kinuko
TBR-ing danakj for adding more base/ DEPS in platform.
4 years, 11 months ago (2016-01-08 14:53:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568433005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568433005/1
4 years, 11 months ago (2016-01-08 14:53:57 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/143007)
4 years, 11 months ago (2016-01-08 15:04:23 UTC) #16
danakj
LGTM
4 years, 11 months ago (2016-01-08 19:43:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568433005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568433005/1
4 years, 11 months ago (2016-01-08 23:09:41 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-09 00:38:08 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2016-01-09 00:39:18 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc2335ab3bfc8f9bcbacf4a1264ece280b73c288
Cr-Commit-Position: refs/heads/master@{#368473}

Powered by Google App Engine
This is Rietveld 408576698