Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Side by Side Diff: third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp

Issue 1568433005: Platform WebUnitTestSupport onion soup: remove more indirect methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY 14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY 17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
20 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 20 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
21 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 21 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "platform/testing/UnitTestHelpers.h" 26 #include "platform/testing/UnitTestHelpers.h"
27 27
28 #include "base/files/file_path.h" 28 #include "base/files/file_path.h"
29 #include "base/files/file_util.h" 29 #include "base/files/file_util.h"
30 #include "base/message_loop/message_loop.h"
30 #include "base/path_service.h" 31 #include "base/path_service.h"
32 #include "platform/SharedBuffer.h"
31 #include "public/platform/Platform.h" 33 #include "public/platform/Platform.h"
32 #include "public/platform/WebTaskRunner.h" 34 #include "public/platform/WebTaskRunner.h"
33 #include "public/platform/WebThread.h" 35 #include "public/platform/WebThread.h"
34 #include "public/platform/WebTraceLocation.h" 36 #include "public/platform/WebTraceLocation.h"
35 #include "public/platform/WebUnitTestSupport.h" 37 #include "public/platform/WebUnitTestSupport.h"
38 #include "wtf/text/StringUTF8Adaptor.h"
36 39
37 namespace blink { 40 namespace blink {
38 namespace testing { 41 namespace testing {
39 42
40 class QuitTask : public WebTaskRunner::Task { 43 class QuitTask : public WebTaskRunner::Task {
41 public: 44 public:
42 virtual void run() 45 virtual void run()
43 { 46 {
44 Platform::current()->unitTestSupport()->exitRunLoop(); 47 exitRunLoop();
45 } 48 }
46 }; 49 };
47 50
48 void runPendingTasks() 51 void runPendingTasks()
49 { 52 {
50 Platform::current()->currentThread()->taskRunner()->postTask(BLINK_FROM_HERE , new QuitTask); 53 Platform::current()->currentThread()->taskRunner()->postTask(BLINK_FROM_HERE , new QuitTask);
51 Platform::current()->unitTestSupport()->enterRunLoop(); 54 enterRunLoop();
52 } 55 }
53 56
54 String blinkRootDir() 57 String blinkRootDir()
55 { 58 {
56 base::FilePath path; 59 base::FilePath path;
57 base::PathService::Get(base::DIR_SOURCE_ROOT, &path); 60 base::PathService::Get(base::DIR_SOURCE_ROOT, &path);
58 path = path.Append(FILE_PATH_LITERAL("third_party/WebKit")); 61 path = path.Append(FILE_PATH_LITERAL("third_party/WebKit"));
59 path = base::MakeAbsoluteFilePath(path); 62 path = base::MakeAbsoluteFilePath(path);
60 return String::fromUTF8(path.MaybeAsASCII().c_str()); 63 return String::fromUTF8(path.MaybeAsASCII().c_str());
61 } 64 }
62 65
66 PassRefPtr<SharedBuffer> readFromFile(const String& path)
67 {
68 StringUTF8Adaptor utf8(path);
69 base::FilePath file_path = base::FilePath::FromUTF8Unsafe(
70 std::string(utf8.data(), utf8.length()));
71 std::string buffer;
72 base::ReadFileToString(file_path, &buffer);
73 return SharedBuffer::create(buffer.data(), buffer.size());
74 }
75
76 void enterRunLoop()
77 {
78 base::MessageLoop::current()->Run();
79 }
80
81 void exitRunLoop()
82 {
83 base::MessageLoop::current()->QuitWhenIdle();
84 }
85
63 } 86 }
64 } 87 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/testing/UnitTestHelpers.h ('k') | third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698